From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YL6zY-0006wx-DR for qemu-devel@nongnu.org; Tue, 10 Feb 2015 04:20:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YL6zX-0002vV-Kr for qemu-devel@nongnu.org; Tue, 10 Feb 2015 04:20:24 -0500 Message-ID: <54D9CD3C.5050307@redhat.com> Date: Tue, 10 Feb 2015 10:19:56 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 14/46] cpu-exec: drop dead assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Michael Tokarev Cc: QEMU Trivial , QEMU Developers On 10/02/2015 10:15, Peter Maydell wrote: > > - tb = (TranslationBlock *)(next_tb & ~TB_EXIT_MASK); > > next_tb = 0; > > break; > > case TB_EXIT_ICOUNT_EXPIRED: > > True, I guess, but presumably this means we're doing unnecessary > work in the next time round the loop re-finding the tb which we > already had... This is the TB_EXIT_REQUESTED case though: once the iothread runs who knows what happens. You might get an interrupt or a system reset that diverts execution away from tb. Paolo