From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44740) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLE8E-0008Or-1v for qemu-devel@nongnu.org; Tue, 10 Feb 2015 11:57:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLE8A-0007MR-TI for qemu-devel@nongnu.org; Tue, 10 Feb 2015 11:57:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLE8A-0007MB-M4 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 11:57:46 -0500 Message-ID: <54DA3880.2020705@redhat.com> Date: Tue, 10 Feb 2015 09:57:36 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423584999-13946-1-git-send-email-dgilbert@redhat.com> <1423584999-13946-3-git-send-email-dgilbert@redhat.com> <20150210164720.GK400@redhat.com> In-Reply-To: <20150210164720.GK400@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8p2LgFVnRJfM9p2PJ3JPBa8EomiNggFJf" Subject: Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , "Dr. David Alan Gilbert (git)" Cc: amit.shah@redhat.com, pbonzini@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8p2LgFVnRJfM9p2PJ3JPBa8EomiNggFJf Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/10/2015 09:47 AM, Daniel P. Berrange wrote: > On Tue, Feb 10, 2015 at 04:16:38PM +0000, Dr. David Alan Gilbert (git) = wrote: >> From: "Dr. David Alan Gilbert" >> >> Once a qemu has been started with -incoming pause the s/pause the/pause, the/ >> migration can be started by issuing: >> >> migrate -u uri >> >> Signed-off-by: Dr. David Alan Gilbert >> --- >=20 > Hmm, the 'unpause' codepath doesn't really share anything with the exis= ting > codepath. Also the URIs for the existing migrate command are not quite = the > same as the URIs for the incoming migrate side. This would suggest to m= e > that it might be better to have a separate 'migrate-incoming' command i= n > the monitor rather than overload the existing 'migrate' command. >=20 > Also having a separate command will make it possible to detect that thi= s > feature is supported from libvirt, since I don't think QMP introspectio= n > provides enough info to detect it based on the new arg to existing > commands. Agree, a new command for QMP would be better (it serves as both the new command to use, and the witness that the '-incoming pause:' command line works). The HMP 'migrate -u' is just fine, though (it's fine to have a single HMP command smart enough to call out to two different QMP commands= ). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8p2LgFVnRJfM9p2PJ3JPBa8EomiNggFJf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU2jiAAAoJEKeha0olJ0NqSmkIAKivMQBo/unVsye+JnoEZZe4 JJXgTn31GGIzcZjPM3ko55PDRFNm8C/5AVroU2sDkDNicMq69tjWf4qSX3epBW8c Gb6EAX7qcIEZfp2CYAhDb6quSe5TqSfxBH2vCEVYQXOwliWLBt1xkszrkYvbNL48 kj+WfYgC+5+aOLlRqscfDLAwCiLN4EIzvAqB9F+TCq/Ww7uGitM36cROWKv2wDLW RXF5IZqUUx082u++oG63GfbqLpAM0+WdYxlyHsH9fCabnLdmFw08L71bbaHFnAqR Jtw3OoRdOJP2CrrGp2nXhYyYtQR6eYSh60sk1+0/6Do3lzCYah1cl4FBiI4BWas= =nRjC -----END PGP SIGNATURE----- --8p2LgFVnRJfM9p2PJ3JPBa8EomiNggFJf--