Re: [Qemu-devel] [PATCH v3 00/12] qcow2: Add new overlap check functions

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1302 bytes --]

On 02/09/2015 12:25 PM, Max Reitz wrote:
> As has been requested, this series adds new overlap check functions to
> the qcow2 code. My local branch is called "qcow2-improved-overlap-v1",
> but I am not so sure whether it is actually an improvement; that is left
> for you to decide, dear reviewers.
> 
> v3:
> - Patch 1:
>   - s/few memory/little memory/ [Eric]
>   - s/2014/2015/ [Eric]
>   - s/of a or a/of or a/ [Eric]
>   - Use nb_clusters_minus_one instead of nb_clusters, because
>     nb_clusters == 0 is invalid [Eric]
>   - Drop cached_windows_index [Stefan]
>   - Reset current_nb_clusters to 1 when a new range starts in the
>     algorithm which rebuilds the fragment list from the bitmap
>     representation
> - Patch 3: Added a TODO comment that the user should be able to override
>   the default cache size limit
> - Patch 8: As the patch "qcow2: Buffer L1 table in snapshot refcount
>   update" has been dropped, this patch was changed to no longer rely on
>   it
> - Patch 11: Replaced the size limit for a snapshot's L1 table by
>   QCOW_MAX_L1_SIZE (was: INT_MAX / sizeof(uint64_t)) [Eric]

On this one, it was actually Stefan that spotted it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]