From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLI3v-0004PF-3i for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:09:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLI3r-0008Bc-S1 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:09:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLI3r-0008Ab-JP for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:09:35 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1AL9YDH024352 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 10 Feb 2015 16:09:35 -0500 Message-ID: <54DA738D.7000805@redhat.com> Date: Tue, 10 Feb 2015 14:09:33 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423586055-4932-1-git-send-email-armbru@redhat.com> <1423586055-4932-3-git-send-email-armbru@redhat.com> In-Reply-To: <1423586055-4932-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T35dqHJ2nWqBSGnJrqLTEFNoxF5TBcpgX" Subject: Re: [Qemu-devel] [PATCH 2/9] monitor: Clean up around monitor_handle_fd_param() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T35dqHJ2nWqBSGnJrqLTEFNoxF5TBcpgX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/10/2015 09:34 AM, Markus Armbruster wrote: > monitor_handle_fd_param() is a wrapper around > monitor_handle_fd_param2() that feeds errors to qerror_report_err() > instead of returning them. qerror_report_err() is inappropriate in > many contexts. monitor_handle_fd_param() looks simpler than > monitor_handle_fd_param2(), which tempts use. Remove the temptation: > drop the wrapper and open-code the (trivial) error handling instead. >=20 > Replace the open-coded qerror_report_err() by error_report_err() in > places that already use error_report(). Turns out that's everywhere. >=20 > While there, rename monitor_handle_fd_param2() to monitor_fd_param(). >=20 > Signed-off-by: Markus Armbruster > --- > hw/i386/kvm/pci-assign.c | 5 ++--- > hw/scsi/vhost-scsi.c | 2 +- > include/monitor/monitor.h | 3 +-- > monitor.c | 15 +-------------- > net/socket.c | 4 +++- > net/tap.c | 11 ++++++++--- > 6 files changed, 16 insertions(+), 24 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --T35dqHJ2nWqBSGnJrqLTEFNoxF5TBcpgX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU2nONAAoJEKeha0olJ0Nq3zQH/iDK6ZfCGazHAiQvss8il1oh BCRUCT5bohNv6XWk+I1t/RrmZcY0xgQ3Tn5A2a8d+kHJwsD222P4x1TSVlJg5y+K s8QHjXyisYCopsF28N61x8gt7Q8SKHQyg394S11Pp+2QOL5RYHEdriMWx87ejMxk jF2eucNIfdz1ji92Gx7632JwDlvIHDL2DsZ15Fxyod05vBEdxdHozMdg5WmPhTm7 d1orqAQ2yo7SoIz9foPxT0zpJNyBsntM3SdSkw/ZHJhBHLvFLo71xZ48h1uIdKxi jhkAj9BjBdJLfVFxgXz5BKTmJl0fPOOvbvxieiadGT+5wMdvgd1fBiHODMLQ/Vo= =NkJs -----END PGP SIGNATURE----- --T35dqHJ2nWqBSGnJrqLTEFNoxF5TBcpgX--