From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45526) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLINH-0000YJ-0j for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:29:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLINC-0004hx-HO for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:29:38 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLINC-0004hd-AP for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:29:34 -0500 Message-ID: <54DA783C.3080403@redhat.com> Date: Tue, 10 Feb 2015 16:29:32 -0500 From: John Snow MIME-Version: 1.0 References: <1422356197-5285-1-git-send-email-vsementsov@parallels.com> <1422356197-5285-4-git-send-email-vsementsov@parallels.com> In-Reply-To: <1422356197-5285-4-git-send-email-vsementsov@parallels.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v2 3/8] block: BdrvDirtyBitmap serialization interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, den@openvz.org On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: > Several functions to provide necessary access to BdrvDirtyBitmap for > block-migration.c > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 36 ++++++++++++++++++++++++++++++++++++ > include/block/block.h | 12 ++++++++++++ > 2 files changed, 48 insertions(+) > > diff --git a/block.c b/block.c > index 6d3f0b2..9860fc1 100644 > --- a/block.c > +++ b/block.c > @@ -5552,6 +5552,42 @@ void bdrv_clear_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap) > hbitmap_reset(bitmap->bitmap, 0, bitmap->size); > } > > +const char *bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap) > +{ > + return bitmap->name; > +} > + > +uint64_t bdrv_dirty_bitmap_data_size(const BdrvDirtyBitmap *bitmap, > + uint64_t count) > +{ > + return hbitmap_data_size(bitmap->bitmap, count); > +} > + > +void bdrv_dirty_bitmap_serialize_part(const BdrvDirtyBitmap *bitmap, > + uint8_t *buf, uint64_t start, > + uint64_t count) > +{ > + hbitmap_serialize_part(bitmap->bitmap, buf, start, count); > +} > + > +void bdrv_dirty_bitmap_deserialize_part(BdrvDirtyBitmap *bitmap, > + uint8_t *buf, uint64_t start, > + uint64_t count) > +{ > + hbitmap_deserialize_part(bitmap->bitmap, buf, start, count); > +} > + > +void bdrv_dirty_bitmap_deserialize_part0(BdrvDirtyBitmap *bitmap, > + uint64_t start, uint64_t count) > +{ > + hbitmap_deserialize_part0(bitmap->bitmap, start, count); > +} > + > +void bdrv_dirty_bitmap_deserialize_finish(BdrvDirtyBitmap *bitmap) > +{ > + hbitmap_deserialize_finish(bitmap->bitmap); > +} > + > static void bdrv_set_dirty(BlockDriverState *bs, int64_t cur_sector, > int nr_sectors) > { > diff --git a/include/block/block.h b/include/block/block.h > index 6cf067f..0890cd2 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -460,6 +460,18 @@ void bdrv_set_dirty_iter(struct HBitmapIter *hbi, int64_t offset); > int64_t bdrv_get_dirty_count(BlockDriverState *bs, BdrvDirtyBitmap *bitmap); > > void bdrv_print_dirty_bitmap(BdrvDirtyBitmap *bitmap); > +const char *bdrv_dirty_bitmap_name(const BdrvDirtyBitmap *bitmap); > +uint64_t bdrv_dirty_bitmap_data_size(const BdrvDirtyBitmap *bitmap, > + uint64_t count); > +void bdrv_dirty_bitmap_serialize_part(const BdrvDirtyBitmap *bitmap, > + uint8_t *buf, uint64_t start, > + uint64_t count); > +void bdrv_dirty_bitmap_deserialize_part(BdrvDirtyBitmap *bitmap, > + uint8_t *buf, uint64_t start, > + uint64_t count); > +void bdrv_dirty_bitmap_deserialize_part0(BdrvDirtyBitmap *bitmap, > + uint64_t start, uint64_t count); > +void bdrv_dirty_bitmap_deserialize_finish(BdrvDirtyBitmap *bitmap); > > void bdrv_enable_copy_on_read(BlockDriverState *bs); > void bdrv_disable_copy_on_read(BlockDriverState *bs); > Reviewed-by: John Snow