From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45902) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLIOe-0002l9-4t for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:31:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLIOa-00062W-Vt for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:31:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36579) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLIOa-00062I-5y for qemu-devel@nongnu.org; Tue, 10 Feb 2015 16:31:00 -0500 Message-ID: <54DA7892.2040701@redhat.com> Date: Tue, 10 Feb 2015 16:30:58 -0500 From: John Snow MIME-Version: 1.0 References: <1422356197-5285-1-git-send-email-vsementsov@parallels.com> <1422356197-5285-6-git-send-email-vsementsov@parallels.com> In-Reply-To: <1422356197-5285-6-git-send-email-vsementsov@parallels.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC v2 5/8] block: add bdrv_dirty_bitmap_enabled() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladimir Sementsov-Ogievskiy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com, stefanha@redhat.com, den@openvz.org On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block.c | 5 +++++ > include/block/block.h | 1 + > 2 files changed, 6 insertions(+) > > diff --git a/block.c b/block.c > index 8ab724b..15fc621 100644 > --- a/block.c > +++ b/block.c > @@ -5551,6 +5551,11 @@ uint64_t bdrv_dirty_bitmap_granularity(BlockDriverState *bs, > return bitmap->granularity; > } > > +bool bdrv_dirty_bitmap_enabled(BdrvDirtyBitmap *bitmap) > +{ > + return bitmap->enabled; > +} > + > void bdrv_dirty_iter_init(BlockDriverState *bs, > BdrvDirtyBitmap *bitmap, HBitmapIter *hbi) > { > diff --git a/include/block/block.h b/include/block/block.h > index 648b0a9..7b49d98 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -449,6 +449,7 @@ BlockDirtyInfoList *bdrv_query_dirty_bitmaps(BlockDriverState *bs); > uint64_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs); > uint64_t bdrv_dirty_bitmap_granularity(BlockDriverState *bs, > BdrvDirtyBitmap *bitmap); > +bool bdrv_dirty_bitmap_enabled(BdrvDirtyBitmap *bitmap); > int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, int64_t sector); > void bdrv_set_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap *bitmap, > int64_t cur_sector, int nr_sectors); > I wrote something similar in my incremental backup series. I'm submitting a new incremental backup series (v12!) soon which might have /slightly/ different semantics for enabled/disabled bitmaps. I don't think you'll need this patch, but in case you do need it: Reviewed-by: John Snow