From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53363) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLJ5z-0000AB-1g for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:15:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLJ5v-0007aa-Iz for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:15:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLJ5u-0007Xg-U5 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:15:47 -0500 Message-ID: <54DA8311.6000804@redhat.com> Date: Tue, 10 Feb 2015 17:15:45 -0500 From: John Snow MIME-Version: 1.0 References: <1423532117-14490-1-git-send-email-jsnow@redhat.com> <1423532117-14490-4-git-send-email-jsnow@redhat.com> <54DA828A.2010206@redhat.com> In-Reply-To: <54DA828A.2010206@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 03/17] block: Introduce bdrv_dirty_bitmap_granularity() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 02/10/2015 05:13 PM, Max Reitz wrote: > On 2015-02-09 at 20:35, John Snow wrote: >> This returns the granularity (in bytes) of dirty bitmap, >> which matches the QMP interface and the existing query >> interface. >> >> Small adjustments are made to ensure that granularity-- in bytes-- >> is handled consistently as a uint64_t throughout the code. > > Just asking whether you want to adjust the following, too: "int > granularity" in mirror_free_init() (the granularity is stored as an 64 > bit integer, but the value is limited by qmp_drive_mirror() to stay > between 512 and 64M, and is defined to be a uint32_t by > qapi/block-core.json). > > It's fine from my perspective, so my R-b stands, but it looked like it > might conflict with "is handled consistently". :-) > > Max > >> Signed-off-by: John Snow >> --- >> block.c | 17 +++++++++++------ >> include/block/block.h | 3 ++- >> 2 files changed, 13 insertions(+), 7 deletions(-) I'll take a look! Every time I change a type I have to change ten more. It is a ceaseless game of whackamole. When I inevitably need to change the QMP parameter name again, I'll fix this while I'm at it.