From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLJ9f-0003Cl-5Z for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:19:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLJ9b-0002LP-V4 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:19:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:52572) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLJ9b-0002LC-N4 for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:19:35 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1AMJZFQ022853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 10 Feb 2015 17:19:35 -0500 Message-ID: <54DA83F5.2020501@redhat.com> Date: Tue, 10 Feb 2015 15:19:33 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423598552-24301-1-git-send-email-mreitz@redhat.com> In-Reply-To: <1423598552-24301-1-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iWtHF6uJV5XGvii2S84hlLC8D0UTvkLRs" Subject: Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iWtHF6uJV5XGvii2S84hlLC8D0UTvkLRs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/10/2015 01:02 PM, Max Reitz wrote: > Under certain circumstances, making the refcount table grow can result > in leaking clusters. The first patch fixes at least some of those > circumstances (maybe there are more, but these are the ones I am aware > of), and the second patch adds a test case. >=20 >=20 > Max Reitz (2): > qcow2: Respect new_block in alloc_refcount_block() > iotests: Add tests for refcount table growth Series: Reviewed-by: Eric Blake How'd you find the leak? >=20 > block/qcow2-refcount.c | 16 ++++++- > tests/qemu-iotests/121 | 102 +++++++++++++++++++++++++++++++++++++= ++++++++ > tests/qemu-iotests/121.out | 23 ++++++++++ > tests/qemu-iotests/group | 1 + > 4 files changed, 140 insertions(+), 2 deletions(-) > create mode 100755 tests/qemu-iotests/121 > create mode 100644 tests/qemu-iotests/121.out >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --iWtHF6uJV5XGvii2S84hlLC8D0UTvkLRs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU2oP1AAoJEKeha0olJ0Nqm1MH/iXK7BL5eIc0IDQQJOODyaZS T4/AHlho1bw+qyYL3aq+5uGFlUbrX98SqEdBlI5KII7RlAnQ3UyH9Ao1HXhOpna9 c9CD8CiGz0lDytCkm+eUTPewOQfm/ziOb8x5dWp4z7knqJD1hHID/SqL/tZNCL8C 4bc/gPZgME6HSrDBOrCp3iJFGGi/wlt2M1ZbMBbjTDqzXtRDw1R6ygWjqKCtZf1g ot47+AVSK0+vpTqru0iUlTsFsBX28V9Rmm7Dx3DbBKPPdknYTRqJ+IQ+hw3B+fRE EvJlVabfnrbF/9sC0Ggv3YviA35nLR2UCZfTzJ0gcAU2gT7QOuehRP5GwjsfVYA= =36LU -----END PGP SIGNATURE----- --iWtHF6uJV5XGvii2S84hlLC8D0UTvkLRs--