qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block()
Date: Tue, 10 Feb 2015 17:21:15 -0500	[thread overview]
Message-ID: <54DA845B.6040004@redhat.com> (raw)
In-Reply-To: <54DA83F5.2020501@redhat.com>

On 2015-02-10 at 17:19, Eric Blake wrote:
> On 02/10/2015 01:02 PM, Max Reitz wrote:
>> Under certain circumstances, making the refcount table grow can result
>> in leaking clusters. The first patch fixes at least some of those
>> circumstances (maybe there are more, but these are the ones I am aware
>> of), and the second patch adds a test case.
>>
>>
>> Max Reitz (2):
>>    qcow2: Respect new_block in alloc_refcount_block()
>>    iotests: Add tests for refcount table growth
> Series:
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> How'd you find the leak?

Test 015 failed with refcount_bits=32 and refcount_bits=64 after my 
refcount_order series; but strangely only if the recent qcow2 cache 
patch 
(http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg00786.html) 
was applied before.

Max

  reply	other threads:[~2015-02-10 22:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-10 20:02 [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block() Max Reitz
2015-02-10 20:02 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2015-02-10 20:02 ` [Qemu-devel] [PATCH 2/2] iotests: Add tests for refcount table growth Max Reitz
2015-02-10 22:19 ` [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in alloc_refcount_block() Eric Blake
2015-02-10 22:21   ` Max Reitz [this message]
2015-02-11  9:47 ` Kevin Wolf
2015-03-02 16:11 ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54DA845B.6040004@redhat.com \
    --to=mreitz@redhat.com \
    --cc=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).