From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54598)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YLJBJ-0004dv-RM
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:21:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YLJBG-000426-Kv
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:21:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39187)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YLJBG-00041q-Dw
	for qemu-devel@nongnu.org; Tue, 10 Feb 2015 17:21:18 -0500
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1AMLH4V011186
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Tue, 10 Feb 2015 17:21:18 -0500
Message-ID: <54DA845B.6040004@redhat.com>
Date: Tue, 10 Feb 2015 17:21:15 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1423598552-24301-1-git-send-email-mreitz@redhat.com>
	<54DA83F5.2020501@redhat.com>
In-Reply-To: <54DA83F5.2020501@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/2] qcow2: Respect new_block in
	alloc_refcount_block()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

On 2015-02-10 at 17:19, Eric Blake wrote:
> On 02/10/2015 01:02 PM, Max Reitz wrote:
>> Under certain circumstances, making the refcount table grow can result
>> in leaking clusters. The first patch fixes at least some of those
>> circumstances (maybe there are more, but these are the ones I am aware
>> of), and the second patch adds a test case.
>>
>>
>> Max Reitz (2):
>>    qcow2: Respect new_block in alloc_refcount_block()
>>    iotests: Add tests for refcount table growth
> Series:
> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> How'd you find the leak?

Test 015 failed with refcount_bits=32 and refcount_bits=64 after my 
refcount_order series; but strangely only if the recent qcow2 cache 
patch 
(http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg00786.html) 
was applied before.

Max