From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>, sfeldma@gmail.com
Cc: jiri@resnulli.us, roopa@cumulusnetworks.com,
john.fastabend@gmail.com, qemu-devel@nongnu.org,
dsahern@gmail.com, jasowang@redhat.com
Subject: Re: [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device
Date: Wed, 11 Feb 2015 11:05:26 +0100 [thread overview]
Message-ID: <54DB2966.6030409@redhat.com> (raw)
In-Reply-To: <20150211094936.GA336@stefanha-thinkpad.redhat.com>
On 11/02/2015 10:49, Stefan Hajnoczi wrote:
> This poses a new problem: when QEMU is built without rocker the
> QMP/HMP commands fail to link because rocker_find() and friends are
> missing (they live in rocker.c).
>
> There are two options compile out the HMP/QMP commands (see how
> SPICE does this, e.g. query-spice) or provide stub functions that
> return an error to the HMP/QMP client when rocker is unavailable.
Can we just not merge the QMP/HMP commands for now?
Paolo
next prev parent reply other threads:[~2015-02-11 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 6:54 [Qemu-devel] [PATCH v6 00/10] rocker: add new rocker ethernet switch device sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 01/10] net: add MAC address string printer sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 02/10] virtio-net: use qemu_mac_strdup_printf sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 03/10] rocker: add register programming guide sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 04/10] pci: add rocker device ID sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 05/10] pci: add network device class 'other' for network switches sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device sfeldma
2015-02-11 9:49 ` Stefan Hajnoczi
2015-02-11 10:05 ` Paolo Bonzini [this message]
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 07/10] qmp: add rocker device support sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 08/10] rocker: add tests sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 09/10] MAINTAINERS: add rocker sfeldma
2015-02-05 6:54 ` [Qemu-devel] [PATCH v6 10/10] rocker: timestamp on the debug logs helps correlate with events in the VM sfeldma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB2966.6030409@redhat.com \
--to=pbonzini@redhat.com \
--cc=dsahern@gmail.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).