From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLUAx-0003PM-Rh for qemu-devel@nongnu.org; Wed, 11 Feb 2015 05:05:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLUAr-0008RY-Ns for qemu-devel@nongnu.org; Wed, 11 Feb 2015 05:05:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLUAr-0008RP-GL for qemu-devel@nongnu.org; Wed, 11 Feb 2015 05:05:37 -0500 Message-ID: <54DB2966.6030409@redhat.com> Date: Wed, 11 Feb 2015 11:05:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423119261-60904-1-git-send-email-sfeldma@gmail.com> <1423119261-60904-7-git-send-email-sfeldma@gmail.com> <20150211094936.GA336@stefanha-thinkpad.redhat.com> In-Reply-To: <20150211094936.GA336@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 06/10] rocker: add new rocker switch device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , sfeldma@gmail.com Cc: jiri@resnulli.us, roopa@cumulusnetworks.com, john.fastabend@gmail.com, qemu-devel@nongnu.org, dsahern@gmail.com, jasowang@redhat.com On 11/02/2015 10:49, Stefan Hajnoczi wrote: > This poses a new problem: when QEMU is built without rocker the > QMP/HMP commands fail to link because rocker_find() and friends are > missing (they live in rocker.c). > > There are two options compile out the HMP/QMP commands (see how > SPICE does this, e.g. query-spice) or provide stub functions that > return an error to the HMP/QMP client when rocker is unavailable. Can we just not merge the QMP/HMP commands for now? Paolo