From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YLUMg-0007BX-Fa
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 05:17:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YLUMb-0004uG-Ew
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 05:17:50 -0500
Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:46880)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1YLUMb-0004u0-7w
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 05:17:45 -0500
Received: by mail-wi0-f169.google.com with SMTP id z2so19061484wiv.0
	for <qemu-devel@nongnu.org>; Wed, 11 Feb 2015 02:17:44 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <54DB2C44.1080904@redhat.com>
Date: Wed, 11 Feb 2015 11:17:40 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1423586055-4932-1-git-send-email-armbru@redhat.com>	<1423586055-4932-2-git-send-email-armbru@redhat.com>	<54DA358B.9060509@redhat.com>
	<20150210220434.GB31950@thinpad.lan.raisama.net>
In-Reply-To: <20150210220434.GB31950@thinpad.lan.raisama.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH 1/9] error: New convenience function
	error_report_err()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>



On 10/02/2015 23:04, Eduardo Habkost wrote:
> $ spatch --sp-file /tmp/error_report.spatch $(git grep -l error_report) > /tmp/error_report.patch

Does it work without specifying any include path?

I tried this a while ago:

@@
identifier s, fld;
@@
  struct s {
    ...
-   QEMUTimer *fld;
+   QEMUTimer fld;
    ...
  }
@@
expression E;
identifier fld;
@@
- E->fld = timer_new_ms(
+ timer_init_ms(&E->fld,
    ...
  );


(The patch is incomplete, but shows the problem).  "spatch --sp-file
timer.cocci hw/arm/pxa2xx.c" misses the first replacement for struct
PXA2xxRTCState, but "spatch --sp-file timer.cocci hmp.c" does it right
in struct MigrationStatus.

Paolo