From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] qemu-img: Fix qemu-img convert -n
Date: Wed, 11 Feb 2015 08:35:00 -0700 [thread overview]
Message-ID: <54DB76A4.10905@redhat.com> (raw)
In-Reply-To: <1423666727-20777-1-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]
On 02/11/2015 07:58 AM, Max Reitz wrote:
> Even when specifying -n to suppress image creation with qemu-img
> convert, that function tried to verify that the target protocol and
> driver are suited for image creation. This verification should be
> suppressed, too (which is what the first patch in this series does, the
> second one adds a test for it).
Reviewed-by: Eric Blake <eblake@redhat.com>
>
>
> Max Reitz (2):
> qemu-img: Fix qemu-img convert -n
> iotests: Add test for qemu-img convert to NBD
>
> qemu-img.c | 50 +++++++++++++++++++------------------
> tests/qemu-iotests/123 | 62 ++++++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/123.out | 9 +++++++
> tests/qemu-iotests/group | 1 +
> 4 files changed, 98 insertions(+), 24 deletions(-)
> create mode 100755 tests/qemu-iotests/123
> create mode 100644 tests/qemu-iotests/123.out
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-02-11 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 14:58 [Qemu-devel] [PATCH 0/2] qemu-img: Fix qemu-img convert -n Max Reitz
2015-02-11 14:58 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2015-02-11 14:58 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for qemu-img convert to NBD Max Reitz
2015-02-11 15:35 ` Eric Blake [this message]
2015-02-13 11:17 ` [Qemu-devel] [PATCH 0/2] qemu-img: Fix qemu-img convert -n Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB76A4.10905@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).