From: Max Reitz <mreitz@redhat.com>
To: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mimu@linux.vnet.ibm.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC v6 2/5] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 081 and 087
Date: Wed, 11 Feb 2015 10:57:29 -0500 [thread overview]
Message-ID: <54DB7BE9.40401@redhat.com> (raw)
In-Reply-To: <1423651057-16204-3-git-send-email-chenxg@linux.vnet.ibm.com>
On 2015-02-11 at 05:37, Xiao Guang Chen wrote:
> This patch fixes an io test suite issue that was introduced with the
> commit c88930a6866e74953e931ae749781e98e486e5c8 'qemu-char: Permit only
> a single "stdio" character device'. The option supresses the creation of
> default devices such as the floopy and cdrom. Output files for test case
> 067, 071, 081 and 087 need to be updated to accommodate this change.
> Use virtio-blk instead of virtio-blk-pci as the device driver for test case
> 067. For virtio-blk-pci is the same with virtio-blk as device driver but
> other platform such as s390 may not recognize the virtio-blk-pci.
>
> Reviewed-by: Max Reitz <mreitz@redhat.com>
I hadn't given my R-b for this patch yet, but it is in fact fine, so it
can stay.
Max
> Reviewed-by: Michael Mueller <mimu@linux.vnet.ibm.com>
> Signed-off-by: Xiao Guang Chen <chenxg@linux.vnet.ibm.com>
> ---
> tests/qemu-iotests/067 | 8 +-
> tests/qemu-iotests/067.out | 266 +--------------------------------------
> tests/qemu-iotests/071.out | 4 -
> tests/qemu-iotests/081.out | 2 -
> tests/qemu-iotests/087.out | 12 --
> tests/qemu-iotests/common | 1 +
> tests/qemu-iotests/common.config | 2 +-
> tests/qemu-iotests/common.qemu | 2 +-
> 8 files changed, 8 insertions(+), 289 deletions(-)
next prev parent reply other threads:[~2015-02-11 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 10:37 [Qemu-devel] [PATCH RFC v6 0/5] Update tests/qemu-iotests failing cases for the s390 platform Xiao Guang Chen
2015-02-11 10:37 ` [Qemu-devel] [PATCH RFC v6 1/5] qemu-iotests: qemu machine type support Xiao Guang Chen
2015-02-11 10:37 ` [Qemu-devel] [PATCH RFC v6 2/5] qemu-iotests: run qemu with -nodefaults and fix 067, 071, 081 and 087 Xiao Guang Chen
2015-02-11 15:57 ` Max Reitz [this message]
2015-02-11 10:37 ` [Qemu-devel] [PATCH RFC v6 3/5] qemu-iotests: s390x: fix test 041 Xiao Guang Chen
2015-02-11 10:37 ` [Qemu-devel] [PATCH RFC v6 4/5] qemu-iotests: s390x: fix test 055 Xiao Guang Chen
2015-02-11 10:37 ` [Qemu-devel] [PATCH RFC v6 5/5] qemu-iotests: s390x: fix test 051 Xiao Guang Chen
2015-02-11 16:00 ` Max Reitz
2015-02-11 16:23 ` Markus Armbruster
2015-02-11 16:24 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB7BE9.40401@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=chenxg@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=mimu@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).