Re: [Qemu-devel] [PATCH 0/6] TriCore: Add RRR1 and RRR2 instructions

[Bastian Koppelmann <kbastian@mail.uni-paderborn.de>]

On 02/10/2015 03:18 PM, Bastian Koppelmann wrote:
> Hi,
>
> the patchset fixes two minor bugs and takes care of all the packed/fixed point
> mac instructions. So far I only implemented all the multiply-add instructions,
> since the multiply-sub instructions are similar and I don't want the reviewers
> to find the same mistakes twice. Once these are reviewed I will send another
> patchset containing all the multiply-sub instructions.
> I do plan on mirroring the multiply-add instructions, which seems okay. However
> if there are ideas to make this more clean, let me know.
>
> Cheers,
> Bastian
>
> Bastian Koppelmann (6):
>    target-tricore: Fix RLC_ADDI, RLC_ADDIH using wrong microcode helper
>    target-tricore: fix msub32_suov return wrong results
>    target-tricore: Add instructions of RRR2 opcode format
>    target-tricore: Add instructions of RRR1 opcode format, which have
>      0x83 as first opcode
>    target-tricore: Add instructions of RRR1 opcode format, which have
>      0x43 as first opcode
>    target-tricore: Add instructions of RRR1 opcode format, which have
>      0xc3 as first opcode
>
>   target-tricore/helper.h          |    9 +
>   target-tricore/op_helper.c       |  374 +++++++++-
>   target-tricore/translate.c       | 1391 ++++++++++++++++++++++++++++++++++++--
>   target-tricore/tricore-opcodes.h |   10 +-
>   4 files changed, 1728 insertions(+), 56 deletions(-)
>
> --
> 2.3.0
>
>
Again I forgot to run checkpatch. I'm really sorry about that. I'll fix 
this and send a v2.

Cheers,
Bastian