From: Paolo Bonzini <pbonzini@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] spice: fix memory leak
Date: Wed, 11 Feb 2015 17:44:38 +0100 [thread overview]
Message-ID: <54DB86F6.6060005@redhat.com> (raw)
In-Reply-To: <1423673041-13522-1-git-send-email-kraxel@redhat.com>
On 11/02/2015 17:44, Gerd Hoffmann wrote:
> Found by coverity.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> monitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/monitor.c b/monitor.c
> index c3cc060..29d7e5b 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -1101,6 +1101,7 @@ static int client_migrate_info(Monitor *mon, const QDict *qdict,
> if (strcmp(protocol, "spice") == 0) {
> if (!qemu_using_spice(&err)) {
> qerror_report_err(err);
> + error_free(local_err);
> return -1;
> }
>
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2015-02-11 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-11 16:44 [Qemu-devel] [PATCH] spice: fix memory leak Gerd Hoffmann
2015-02-11 16:44 ` Paolo Bonzini [this message]
2015-02-16 8:30 ` Michael Tokarev
2015-02-16 9:40 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2014-12-05 3:31 [Qemu-devel] " arei.gonglei
2014-12-05 4:59 ` Eric Blake
2014-12-05 5:01 ` Gonglei
2014-12-05 7:17 ` Gerd Hoffmann
2014-12-05 7:22 ` Gonglei
2014-12-05 7:39 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB86F6.6060005@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).