From: Eric Blake <eblake@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: quintela@redhat.com, liang.z.li@intel.com, qemu-devel@nongnu.org,
amit.shah@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] Add migrate -u option for -incoming pause
Date: Wed, 11 Feb 2015 10:10:29 -0700 [thread overview]
Message-ID: <54DB8D05.1030704@redhat.com> (raw)
In-Reply-To: <20150211164853.GF2371@work-vm>
[-- Attachment #1: Type: text/plain, Size: 883 bytes --]
On 02/11/2015 09:48 AM, Dr. David Alan Gilbert wrote:
>> Agree, a new command for QMP would be better (it serves as both the new
>> command to use, and the witness that the '-incoming pause:' command line
>> works). The HMP 'migrate -u' is just fine, though (it's fine to have a
>> single HMP command smart enough to call out to two different QMP commands).
>
> I've split it out as you all suggested; I made it migrate-incoming and
> also made an HMP migrate_incoming; although as you say you can merge them,
> I just find it easier when they match - if you're used to using an HMP
> command it's easier when you need to find the matching QMP command.
Fair enough; HMP exists for ease-of-use, so whichever way you found
easier to code is sufficient :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-02-11 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-10 16:16 [Qemu-devel] [PATCH 0/3] -incoming pause Dr. David Alan Gilbert (git)
2015-02-10 16:16 ` [Qemu-devel] [PATCH 1/3] Add " Dr. David Alan Gilbert (git)
2015-02-10 16:42 ` Juan Quintela
2015-02-10 16:16 ` [Qemu-devel] [PATCH 2/3] Add migrate -u option for " Dr. David Alan Gilbert (git)
2015-02-10 16:47 ` Daniel P. Berrange
2015-02-10 16:57 ` Eric Blake
2015-02-11 16:48 ` Dr. David Alan Gilbert
2015-02-11 17:10 ` Eric Blake [this message]
2015-02-10 16:59 ` Dr. David Alan Gilbert
2015-02-10 17:00 ` Juan Quintela
2015-02-11 16:53 ` Dr. David Alan Gilbert
2015-02-10 16:16 ` [Qemu-devel] [PATCH 3/3] Document -incoming options Dr. David Alan Gilbert (git)
2015-02-10 17:00 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DB8D05.1030704@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=dgilbert@redhat.com \
--cc=liang.z.li@intel.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).