Re: [Qemu-devel] [PATCH v12 11/17] block: add BdrvDirtyBitmap documentation

[Max Reitz <mreitz@redhat.com>]

On 2015-02-09 at 20:35, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   block.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/block.c b/block.c
> index 3c0989c..e065694 100644
> --- a/block.c
> +++ b/block.c
> @@ -60,11 +60,11 @@
>    *     or enabled. A frozen bitmap can only abdicate() or reclaim().
>    */
>   struct BdrvDirtyBitmap {
> -    HBitmap *bitmap;
> -    BdrvDirtyBitmap *successor;
> -    int64_t size;
> -    char *name;
> -    bool disabled;
> +    HBitmap *bitmap;            /* Dirty sector bitmap implementation */
> +    BdrvDirtyBitmap *successor; /* Anonymous child; implies frozen status */
> +    char *name;                 /* Optional non-empty unique ID */
> +    int64_t size;               /* Size of the bitmap (Number of sectors) */
> +    bool disabled;              /* Bitmap is read-only */
>       QLIST_ENTRY(BdrvDirtyBitmap) list;
>   };
>   

Reviewed-by: Max Reitz <mreitz@redhat.com>