From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39980)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YLckB-0007GO-ID
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 14:14:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YLck8-00011C-5E
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 14:14:39 -0500
Received: from mx1.redhat.com ([209.132.183.28]:38199)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mreitz@redhat.com>) id 1YLck7-000116-TT
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 14:14:36 -0500
Message-ID: <54DBAA19.5090501@redhat.com>
Date: Wed, 11 Feb 2015 14:14:33 -0500
From: Max Reitz <mreitz@redhat.com>
MIME-Version: 1.0
References: <1423532117-14490-1-git-send-email-jsnow@redhat.com>
	<1423532117-14490-12-git-send-email-jsnow@redhat.com>
In-Reply-To: <1423532117-14490-12-git-send-email-jsnow@redhat.com>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v12 11/17] block: add BdrvDirtyBitmap
	documentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com

On 2015-02-09 at 20:35, John Snow wrote:
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   block.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/block.c b/block.c
> index 3c0989c..e065694 100644
> --- a/block.c
> +++ b/block.c
> @@ -60,11 +60,11 @@
>    *     or enabled. A frozen bitmap can only abdicate() or reclaim().
>    */
>   struct BdrvDirtyBitmap {
> -    HBitmap *bitmap;
> -    BdrvDirtyBitmap *successor;
> -    int64_t size;
> -    char *name;
> -    bool disabled;
> +    HBitmap *bitmap;            /* Dirty sector bitmap implementation */
> +    BdrvDirtyBitmap *successor; /* Anonymous child; implies frozen status */
> +    char *name;                 /* Optional non-empty unique ID */
> +    int64_t size;               /* Size of the bitmap (Number of sectors) */
> +    bool disabled;              /* Bitmap is read-only */
>       QLIST_ENTRY(BdrvDirtyBitmap) list;
>   };
>   

Reviewed-by: Max Reitz <mreitz@redhat.com>