From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37574) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLfBS-0006lg-CW for qemu-devel@nongnu.org; Wed, 11 Feb 2015 16:51:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLfBN-0008Tn-CB for qemu-devel@nongnu.org; Wed, 11 Feb 2015 16:50:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLfBN-0008Rb-4w for qemu-devel@nongnu.org; Wed, 11 Feb 2015 16:50:53 -0500 Message-ID: <54DBCEBA.5040801@redhat.com> Date: Wed, 11 Feb 2015 16:50:50 -0500 From: Max Reitz MIME-Version: 1.0 References: <1423532117-14490-1-git-send-email-jsnow@redhat.com> <1423532117-14490-17-git-send-email-jsnow@redhat.com> In-Reply-To: <1423532117-14490-17-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v12 16/17] blkdebug: fix "once" rule List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 2015-02-09 at 20:35, John Snow wrote: > Background: > The blkdebug scripts are currently engineered so that when a debug > event occurs, a prefilter browses a master list of parsed rules for a > certain event and adds them to an "active list" of rules to be used for > the forthcoming action, provided the events and state numbers match. > > Then, once the request is received, the last active rule is used to > inject an error if certain parameters match. > > This active list is cleared every time the prefilter injects a new > rule for the first time during a debug event. > > The "once" rule currently causes the error injection, if it is > triggered, to only clear the active list. This is insufficient for > preventing future injections of the same rule. > > Remedy: > This patch /deletes/ the rule from the list that the prefilter > browses, so it is gone for good. In V2, we remove only the rule of > interest from the active list instead of allowing the "once" rule to > clear the entire list of active rules. > > Impact: > This affects iotests 026. Several ENOSPC tests that used "once" can > be seen to have output that shows multiple failure messages. After > this patch, the error messages tend to be smaller and less severe, but > the injection can still be seen to be working. I have patched the > expected output to expect the smaller error messages. > > Signed-off-by: John Snow > --- > block/blkdebug.c | 6 ++++-- > tests/qemu-iotests/026.out | 24 ++++-------------------- > 2 files changed, 8 insertions(+), 22 deletions(-) Well, I think this shouldn't be part of this series, but you can find my R-b here: http://lists.nongnu.org/archive/html/qemu-devel/2015-02/msg01209.html Max