Re: [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n' around error_report/error_setg

[Gonglei <arei.gonglei@huawei.com>]

On 2015/2/11 21:41, Markus Armbruster wrote:
> <arei.gonglei@huawei.com> writes:
> 
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> Yesterday, I found that some files have superfluous '\n' character
>> around error_report/error_setg when reviewed patches.
>>
>> By a simply script, the below files were listed. Classify and fix
>> them. It's suitable for applying via qemu-trivial IMHO.
> 
> You can find my script in commit 312fd5f :)
> 
It's cool, I haven't noticed it before.  :)
>> Gonglei (11):
>>   block: remove superfluous '\n' around error_report/error_setg
>>   a9gtimer: remove superfluous '\n' around error_setg
>>   pl330.c: remove superfluous '\n' around error_setg
>>   numa: remove superfluous '\n' around error_setg
>>   Remove superfluous '\n' around error_report()
>>   vhost-scsi: Remove superfluous '\n' around error_report()
>>   vfio: Remove superfluous '\n' around error_report()
>>   xtensa: Remove superfluous '\n' around error_report()
>>   tpm: Remove superfluous '\n' around error_report()
>>   arm/digic_boards: Remove superfluous '\n' around error_report()
>>   vhost: Remove superfluous '\n' around error_report()
> 
> When I fixed this before, I didn't split it up (commits 312fd5f 6daf194
> be62a2eb).  Splitting it up is fine, of course.  Having the catch-all as
> PATCH 05/11 is a bit odd, though.  Its qemu-img.c hunk could go into
> PATCH 01, because qemu-img is part of the block subsystem.  Not worth a
> respin as far as I'm concerned.
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 
Thanks.

Regards,
-Gonglei