From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41726)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YLiJO-0000Bu-GC
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 20:11:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <arei.gonglei@huawei.com>) id 1YLiJN-0001a8-Fm
	for qemu-devel@nongnu.org; Wed, 11 Feb 2015 20:11:22 -0500
Message-ID: <54DBFD9E.8060808@huawei.com>
Date: Thu, 12 Feb 2015 09:10:54 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <1423627934-11676-1-git-send-email-arei.gonglei@huawei.com>
	<87vbj87ehb.fsf@blackfin.pond.sub.org>
In-Reply-To: <87vbj87ehb.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 00/11] trivial: Remove superfluous '\n'
 around error_report/error_setg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, peter.huangpeng@huawei.com

On 2015/2/11 21:41, Markus Armbruster wrote:
> <arei.gonglei@huawei.com> writes:
> 
>> From: Gonglei <arei.gonglei@huawei.com>
>>
>> Yesterday, I found that some files have superfluous '\n' character
>> around error_report/error_setg when reviewed patches.
>>
>> By a simply script, the below files were listed. Classify and fix
>> them. It's suitable for applying via qemu-trivial IMHO.
> 
> You can find my script in commit 312fd5f :)
> 
It's cool, I haven't noticed it before.  :)
>> Gonglei (11):
>>   block: remove superfluous '\n' around error_report/error_setg
>>   a9gtimer: remove superfluous '\n' around error_setg
>>   pl330.c: remove superfluous '\n' around error_setg
>>   numa: remove superfluous '\n' around error_setg
>>   Remove superfluous '\n' around error_report()
>>   vhost-scsi: Remove superfluous '\n' around error_report()
>>   vfio: Remove superfluous '\n' around error_report()
>>   xtensa: Remove superfluous '\n' around error_report()
>>   tpm: Remove superfluous '\n' around error_report()
>>   arm/digic_boards: Remove superfluous '\n' around error_report()
>>   vhost: Remove superfluous '\n' around error_report()
> 
> When I fixed this before, I didn't split it up (commits 312fd5f 6daf194
> be62a2eb).  Splitting it up is fine, of course.  Having the catch-all as
> PATCH 05/11 is a bit odd, though.  Its qemu-img.c hunk could go into
> PATCH 01, because qemu-img is part of the block subsystem.  Not worth a
> respin as far as I'm concerned.
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> 
Thanks.

Regards,
-Gonglei