From: Gonglei <arei.gonglei@huawei.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "armbru@redhat.com" <armbru@redhat.com>,
"dvaleev@suse.de" <dvaleev@suse.de>,
"agraf@suse.de" <agraf@suse.de>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/4] bootdevcie: change the boot order validation logic
Date: Thu, 12 Feb 2015 15:53:38 +0800 [thread overview]
Message-ID: <54DC5C02.2030702@huawei.com> (raw)
In-Reply-To: <1423293616-10736-1-git-send-email-arei.gonglei@huawei.com>
On 2015/2/7 15:20, Gonglei (Arei) wrote:
> From: Gonglei <arei.gonglei@huawei.com>
>
> The reset logic can be done by both machine reset and
> boot handler. So we shouldn't return error when the boot
> handler callback don't be set in patch 1.
>
> Patch 2 check boot order argument validation
> before vm running.
>
> Patch 3 passing &error_abort instead of NULL.
> Patch 4 update boot order in MachineState in qemu_boot_set
> in order to support changing boot order on other machine type,
> such as sPAPR.
>
> v3 -> v2:
> - rework patch 2 using clearer variable name and coding order. (Maruks)
> - add patch 4 in this patch series because of relevance.
>
> v2 -> v1:
> - add patch 2 suggested by Markus.
> - rework patch 3. (Maruks)
> - add R-by in patch 1.
>
> Dinar Valeev (1):
> bootdevice: update boot_order in MachineState
>
> Gonglei (3):
> bootdevice: remove the check about boot_set_handler
> bootdevice: check boot order argument validation before vm running
> bootdevice: add check in restore_boot_order()
>
> bootdevice.c | 16 ++++++++--------
> vl.c | 23 +++++++++++++++--------
> 2 files changed, 23 insertions(+), 16 deletions(-)
>
Any ideas, Markus? Thanks.
With the Chinese new year during near, a seven day holiday has already
on the way. So I plan to send a pull request on this Sunday. :)
Regards,
-Gonglei
prev parent reply other threads:[~2015-02-12 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-07 7:20 [Qemu-devel] [PATCH v3 0/4] bootdevcie: change the boot order validation logic arei.gonglei
2015-02-07 7:20 ` [Qemu-devel] [PATCH v3 1/4] bootdevice: remove the check about boot_set_handler arei.gonglei
2015-02-12 10:19 ` Markus Armbruster
2015-02-13 2:12 ` Gonglei
2015-02-07 7:20 ` [Qemu-devel] [PATCH v3 2/4] bootdevice: check boot order argument validation before vm running arei.gonglei
2015-02-12 10:19 ` Markus Armbruster
2015-02-13 2:24 ` Gonglei
2015-02-07 7:20 ` [Qemu-devel] [PATCH v3 3/4] bootdevice: add check in restore_boot_order() arei.gonglei
2015-02-07 7:20 ` [Qemu-devel] [PATCH v3 4/4] bootdevice: update boot_order in MachineState arei.gonglei
2015-02-12 10:21 ` Markus Armbruster
2015-02-13 2:44 ` Gonglei
2015-02-12 7:53 ` Gonglei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DC5C02.2030702@huawei.com \
--to=arei.gonglei@huawei.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=dvaleev@suse.de \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).