From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLq6g-000125-Ow for qemu-devel@nongnu.org; Thu, 12 Feb 2015 04:30:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLq6c-0005Ok-PU for qemu-devel@nongnu.org; Thu, 12 Feb 2015 04:30:46 -0500 Received: from mel.act-europe.fr ([194.98.77.210]:34442 helo=smtp.eu.adacore.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLq6c-0005NT-Ev for qemu-devel@nongnu.org; Thu, 12 Feb 2015 04:30:42 -0500 Message-ID: <54DC72B7.5070001@adacore.com> Date: Thu, 12 Feb 2015 10:30:31 +0100 From: Fabien Chouteau MIME-Version: 1.0 References: <1423071188-1085-1-git-send-email-armbru@redhat.com> <1423071188-1085-4-git-send-email-armbru@redhat.com> In-Reply-To: <1423071188-1085-4-git-send-email-armbru@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/8] leon3: Replace unchecked qdev_init() by qdev_init_nofail() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: afaerber@suse.de On 02/04/2015 06:33 PM, Markus Armbruster wrote: > grlib_irqmp_create(), grlib_gptimer_create() and > grlib_apbuart_create() are helpers to create and realize GRLIB > devices. Their only caller leon3_generic_hw_init() doesn't check for > failure. Only the first can actually fail, and only when the caller > fails to set up a pointer property, which is a programming error. > > Replace qdev_init() by qdev_init_nofail(). > > Cc: Fabien Chouteau > Signed-off-by: Markus Armbruster Reviewed-by: Fabien Chouteau Thanks Markus,