From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YLuVq-0002TV-JM
	for qemu-devel@nongnu.org; Thu, 12 Feb 2015 09:13:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YLuVn-0006Ir-EB
	for qemu-devel@nongnu.org; Thu, 12 Feb 2015 09:13:02 -0500
Received: from mx1.redhat.com ([209.132.183.28]:52660)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YLuVn-0006Ig-6W
	for qemu-devel@nongnu.org; Thu, 12 Feb 2015 09:12:59 -0500
Message-ID: <54DCB4DB.6080009@redhat.com>
Date: Thu, 12 Feb 2015 15:12:43 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <20150122085127.5276.53895.stgit@PASHA-ISP.def.inno>
	<20150122085323.5276.64995.stgit@PASHA-ISP.def.inno>
	<54CB62E5.3000807@redhat.com>
	<001c01d04462$17a41f20$46ec5d60$@Dovgaluk@ispras.ru>
	<54D8A78D.2090805@redhat.com>
	<000701d046a4$1899fc30$49cdf490$@Dovgaluk@ispras.ru>
In-Reply-To: <000701d046a4$1899fc30$49cdf490$@Dovgaluk@ispras.ru>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH v8 20/21] replay: command line options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Pavel Dovgaluk <Pavel.Dovgaluk@ispras.ru>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, alex.bennee@linaro.org, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, afaerber@suse.de, fred.konrad@greensocs.com



On 12/02/2015 10:12, Pavel Dovgaluk wrote:
>>> > >
>>> > > Replay for audio adapter will be added in latter patches.
>>> > > Trying to record/replay machine with audio using current
>>> > > set of patches will break the replay.
>> > 
>> > For this case you can try adding a mechanism similar to migration
>> > blockers (replay blockers).
> Do you mean adding flag to vmsd similar to unmigratable?

No, see this in migration/migration.c:

static GSList *migration_blockers;

void migrate_add_blocker(Error *reason)
{
    migration_blockers = g_slist_prepend(migration_blockers, reason);
}

void migrate_del_blocker(Error *reason)
{
    migration_blockers = g_slist_remove(migration_blockers, reason);
}

...

    if (migration_blockers) {
        *errp = error_copy(migration_blockers->data);
        return;
    }

Paolo