From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLvUl-0004UT-3v for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:16:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLvUh-0001Cc-UF for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:15:59 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42701) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLvUh-0001CS-Le for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:15:55 -0500 Message-ID: <54DCC396.4030808@redhat.com> Date: Thu, 12 Feb 2015 08:15:34 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423748990-9709-1-git-send-email-armbru@redhat.com> In-Reply-To: <1423748990-9709-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="FgILidx5HRSrTlk7l3XXD4Ag8bTG4Xj7l" Subject: Re: [Qemu-devel] [PATCH] sheepdog: Fix misleading error messages in sd_snapshot_create() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: mitake.hitoshi@lab.ntt.co.jp, namei.unix@gmail.com, kwolf@redhat.com, sheepdog@lists.wpkg.org, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --FgILidx5HRSrTlk7l3XXD4Ag8bTG4Xj7l Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/12/2015 06:49 AM, Markus Armbruster wrote: > If do_sd_create() fails, it first reports the error returned, then > reports a another one with strerror(errno). errno is meaningless at > that point. >=20 > Report just one error combining the valid information from both > messages. >=20 > Reported-by: Eric Blake > Signed-off-by: Markus Armbruster > --- > Applies on top of my "[PATCH v2 00/10] Clean up around > error_get_pretty(), qerror_report_err()", but rebasing to master would > be trivial. >=20 > block/sheepdog.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --FgILidx5HRSrTlk7l3XXD4Ag8bTG4Xj7l Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU3MOWAAoJEKeha0olJ0NqZIwIAIA0PzGMiO8RrGhNZ9AJH1Iz 0voMV/ohn1PJ2rY4rjW3dxq1bh69hnaqepuQWF6xwDpBa1ggUp9gl+4JKMy9jdFC SoBGJ34ei9qslIc1ukIdJ/2SaWdBBtnsz4GHX5ymXyFFl7GEsjwNaQuJwYec31NL ETb+mpmPDCq2Vqq0BPCHpmnOSrxtFM49RZUqDzY6IxawqrrqqQBGM4Tl+7nmlD0I iaV7hlltEEhrPROCEdYFlWm3aQQ84PRWa75m6ikmaJlNnj/FPAKrfBbIUFuwXFD/ sV5WrkTaY6LWXAIKvCoq7GxbODeop7+4iaDKkKNjx+d+RT5pDOHxPlqPqk/RPUg= =uuCI -----END PGP SIGNATURE----- --FgILidx5HRSrTlk7l3XXD4Ag8bTG4Xj7l--