From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46713) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLvXO-0006eq-PF for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:18:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YLvXL-0002Sn-KX for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:18:42 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YLvXL-0002Rg-Cj for qemu-devel@nongnu.org; Thu, 12 Feb 2015 10:18:39 -0500 Message-ID: <54DCC447.2050306@redhat.com> Date: Thu, 12 Feb 2015 16:18:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423511596-2584-1-git-send-email-ehabkost@redhat.com> <1423511596-2584-3-git-send-email-ehabkost@redhat.com> <20150212152231.16e0f268@nial.brq.redhat.com> In-Reply-To: <20150212152231.16e0f268@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/3] numa: Reject configuration if CPU appears on multiple nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov , Eduardo Habkost Cc: Hu Tao , qemu-devel@nongnu.org, "Michael S. Tsirkin" On 12/02/2015 15:22, Igor Mammedov wrote: > how about replacing a bunch if fprintf's with something like this: > > cpu = 0; > while((cpu = find_next_bit(present_cpus, MAX_CPUMASK_BITS, cpu + 1)) !=MAX_CPUMASK_BITS) > str = g_strdup_printf("%s %d", str, cpu); > > error_report("CPU(s) present in multiple NUMA nodes: %s\n", str); As written above this leaks memory, and there should be no space before the final %s. So it's not that simple. :) But using error_report is nicer indeed, and you can use GString to avoid the leak. Paolo