From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 02/10] error: Use error_report_err() where appropriate
Date: Thu, 12 Feb 2015 08:29:19 -0700 [thread overview]
Message-ID: <54DCC6CF.4030804@redhat.com> (raw)
In-Reply-To: <1423748040-3448-3-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 715 bytes --]
On 02/12/2015 06:33 AM, Markus Armbruster wrote:
> Coccinelle semantic patch:
>
> @@
> expression E;
> @@
> - error_report("%s", error_get_pretty(E));
> - error_free(E);
> + error_report_err(E);
> @@
> expression E, S;
> @@
> - error_report("%s", error_get_pretty(E));
> + error_report_err(E);
> (
> exit(S);
> |
> abort();
> )
>
> Trivial manual touch-ups in block/sheepdog.c.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-02-12 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 13:33 [Qemu-devel] [PATCH v2 00/10] Clean up around error_get_pretty(), qerror_report_err() Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 01/10] error: New convenience function error_report_err() Markus Armbruster
2015-02-12 15:26 ` Eric Blake
2015-02-13 8:08 ` Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 02/10] error: Use error_report_err() where appropriate Markus Armbruster
2015-02-12 15:29 ` Eric Blake [this message]
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 03/10] monitor: Clean up around monitor_handle_fd_param() Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 04/10] monitor: Avoid qerror_report_err() outside QMP command handlers Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 05/10] net: " Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 06/10] numa: " Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 07/10] tpm: " Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 08/10] vl: " Markus Armbruster
2015-02-12 13:33 ` [Qemu-devel] [PATCH v2 09/10] qemu-img: " Markus Armbruster
2015-02-12 13:34 ` [Qemu-devel] [PATCH v2 10/10] qemu-char: " Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DCC6CF.4030804@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).