Re: [Qemu-devel] [PATCH RFC v2 5/8] block: add bdrv_dirty_bitmap_enabled()

[John Snow <jsnow@redhat.com>]

On 02/12/2015 05:54 AM, Vladimir Sementsov-Ogievskiy wrote:
> On 11.02.2015 00:30, John Snow wrote:
>>
>>
>> On 01/27/2015 05:56 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@parallels.com>
>>> ---
>>>   block.c               | 5 +++++
>>>   include/block/block.h | 1 +
>>>   2 files changed, 6 insertions(+)
>>>
>>> diff --git a/block.c b/block.c
>>> index 8ab724b..15fc621 100644
>>> --- a/block.c
>>> +++ b/block.c
>>> @@ -5551,6 +5551,11 @@ uint64_t
>>> bdrv_dirty_bitmap_granularity(BlockDriverState *bs,
>>>       return bitmap->granularity;
>>>   }
>>>
>>> +bool bdrv_dirty_bitmap_enabled(BdrvDirtyBitmap *bitmap)
>>> +{
>>> +    return bitmap->enabled;
>>> +}
>>> +
>>>   void bdrv_dirty_iter_init(BlockDriverState *bs,
>>>                             BdrvDirtyBitmap *bitmap, HBitmapIter *hbi)
>>>   {
>>> diff --git a/include/block/block.h b/include/block/block.h
>>> index 648b0a9..7b49d98 100644
>>> --- a/include/block/block.h
>>> +++ b/include/block/block.h
>>> @@ -449,6 +449,7 @@ BlockDirtyInfoList
>>> *bdrv_query_dirty_bitmaps(BlockDriverState *bs);
>>>   uint64_t bdrv_get_default_bitmap_granularity(BlockDriverState *bs);
>>>   uint64_t bdrv_dirty_bitmap_granularity(BlockDriverState *bs,
>>>                                         BdrvDirtyBitmap *bitmap);
>>> +bool bdrv_dirty_bitmap_enabled(BdrvDirtyBitmap *bitmap);
>>>   int bdrv_get_dirty(BlockDriverState *bs, BdrvDirtyBitmap *bitmap,
>>> int64_t sector);
>>>   void bdrv_set_dirty_bitmap(BlockDriverState *bs, BdrvDirtyBitmap
>>> *bitmap,
>>>                              int64_t cur_sector, int nr_sectors);
>>>
>>
>> I wrote something similar in my incremental backup series. I'm
>> submitting a new incremental backup series (v12!) soon which might
>> have /slightly/ different semantics for enabled/disabled bitmaps.
>>
>> I don't think you'll need this patch, but in case you do need it:
>>
>> Reviewed-by: John Snow <jsnow@redhat.com>
>
> Ok, I don't need it after v12.
>

Yes, my apologies for the churn.