From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38317)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YLyPa-0001dC-3s
	for qemu-devel@nongnu.org; Thu, 12 Feb 2015 13:22:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YLyPW-0000oM-A2
	for qemu-devel@nongnu.org; Thu, 12 Feb 2015 13:22:50 -0500
Received: from mx1.redhat.com ([209.132.183.28]:59119)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YLyPW-0000oF-2A
	for qemu-devel@nongnu.org; Thu, 12 Feb 2015 13:22:46 -0500
Message-ID: <54DCEF6D.6080903@redhat.com>
Date: Thu, 12 Feb 2015 19:22:37 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1423763435-3696-1-git-send-email-ehabkost@redhat.com>
	<1423763435-3696-5-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1423763435-3696-5-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 4/4] numa: Print warning if no node is
 assigned to a CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Hu Tao <hutao@cn.fujitsu.com>, Igor Mammedov <imammedo@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>



On 12/02/2015 18:50, Eduardo Habkost wrote:
> +
> +    if (!bitmap_full(seen_cpus, max_cpus)) {
> +        char *msg;
> +        bitmap_complement(seen_cpus, seen_cpus, max_cpus);
> +        msg = enumerate_cpus(seen_cpus, max_cpus);
> +        error_report("warning: CPU(s) not present in any NUMA nodes: %s", msg);
> +        g_free(msg);
> +    }

What happens if you have a single node (useful to give it a memdev via
-numa node,memdev=...)?  It would be nice in this case to avoid the
warning and assign all CPUs to node 0.

Paolo