From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t
Date: Thu, 12 Feb 2015 22:21:23 -0800 [thread overview]
Message-ID: <54DD97E3.8090905@twiddle.net> (raw)
In-Reply-To: <1423231328-15662-1-git-send-email-peter.maydell@linaro.org>
On 02/06/2015 06:02 AM, Peter Maydell wrote:
> The documentation for sextract64() claims that the return type is
> an int64_t, but the code itself disagrees. Fix the return type to
> conform to the documentation and to bring it into line with
> sextract32(), which returns int32_t.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I quickly eyeballed all the callers and I don't think any of them
> were relying on the unsignedness of the return type.
> ---
> include/qemu/bitops.h | 2 +-
Reviewed-by: Richard Henderson <rth@twiddle.net>
Via trivial?
r~
next prev parent reply other threads:[~2015-02-13 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-06 14:02 [Qemu-devel] [PATCH] bitops.h: sextract64() return type should be int64_t, not uint64_t Peter Maydell
2015-02-13 6:21 ` Richard Henderson [this message]
2015-03-11 11:32 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54DD97E3.8090905@twiddle.net \
--to=rth@twiddle.net \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).