From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMG2j-0004iL-4F for qemu-devel@nongnu.org; Fri, 13 Feb 2015 08:12:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMG2e-0007X0-5G for qemu-devel@nongnu.org; Fri, 13 Feb 2015 08:12:25 -0500 Received: from mail-wi0-x232.google.com ([2a00:1450:400c:c05::232]:51663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMG2d-0007Ws-UH for qemu-devel@nongnu.org; Fri, 13 Feb 2015 08:12:20 -0500 Received: by mail-wi0-f178.google.com with SMTP id em10so11957184wid.5 for ; Fri, 13 Feb 2015 05:12:19 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54DDF830.3090504@redhat.com> Date: Fri, 13 Feb 2015 14:12:16 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1423718462-25566-1-git-send-email-famz@redhat.com> <1423718462-25566-4-git-send-email-famz@redhat.com> <54DCB8DE.4090302@redhat.com> <20150213012129.GA20581@ad.nay.redhat.com> <54DDC623.8000307@redhat.com> <20150213102941.GA19672@ad.nay.redhat.com> <54DDD41A.3080106@redhat.com> <20150213124237.GB1971@fam-t430.nay.redhat.com> In-Reply-To: <20150213124237.GB1971@fam-t430.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] virtio-scsi-dataplane: Use main thread BH to set BDS' aio context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On 13/02/2015 13:42, Fam Zheng wrote: > OK, thanks for elaborating. I think for the sake of single IO thread support we > already started, the best option now is to go as you suggested - move > bdrv_set_aio_context to virtio_scsi_dataplane_start and hotplug callbacks. Yes, no doubt the bug has to be fixed. > Could you review patch 1? (And do we want patch 2?) I don't know. Theoretically yes, in practice the aim is to get rid of vring so the benefit is limited in time... Patch 1 is okay of course. I prefer to document things only once the code actually does what the documentation says, but Kevin and Stefan are free to pick it up if they want to. Paolo