From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMPlW-0004kF-Ne for qemu-devel@nongnu.org; Fri, 13 Feb 2015 18:35:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMPlR-000774-OQ for qemu-devel@nongnu.org; Fri, 13 Feb 2015 18:35:18 -0500 Message-ID: <54DE8A2F.4070109@suse.de> Date: Sat, 14 Feb 2015 00:35:11 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1420644048-16919-1-git-send-email-agraf@suse.de> <1420644048-16919-7-git-send-email-agraf@suse.de> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 06/37] target-ppc: VXSQRT Should Not Be Set for NaNs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Maciej W. Rozycki" Cc: peter.maydell@linaro.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Tom Musta On 12.02.15 23:21, Maciej W. Rozycki wrote: > On Wed, 7 Jan 2015, Alexander Graf wrote: > >> diff --git a/target-ppc/fpu_helper.c b/target-ppc/fpu_helper.c >> index 7f74466..81db60f 100644 >> --- a/target-ppc/fpu_helper.c >> +++ b/target-ppc/fpu_helper.c >> @@ -920,14 +923,16 @@ uint64_t helper_fsqrt(CPUPPCState *env, uint64_t arg) >> >> farg.ll = arg; >> >> - if (unlikely(float64_is_neg(farg.d) && !float64_is_zero(farg.d))) { >> - /* Square root of a negative nonzero number */ >> - farg.ll = fload_invalid_op_excp(env, POWERPC_EXCP_FP_VXSQRT, 1); >> - } else { >> + if (unlikely(float64_is_any_nan(farg.d))) { >> if (unlikely(float64_is_signaling_nan(farg.d))) { >> - /* sNaN square root */ >> + /* sNaN reciprocal square root */ > > This change to the comment looks accidental, compare the changes below. > Should it be reverted? [Found this while resolving merge conflicts.] Nicely spotted. Could you please cook up a small patch fixing it? Thanks! Alex