From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMYPU-0000EW-9l for qemu-devel@nongnu.org; Sat, 14 Feb 2015 03:49:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YMYPR-00026o-4i for qemu-devel@nongnu.org; Sat, 14 Feb 2015 03:49:08 -0500 Received: from s16892447.onlinehome-server.info ([82.165.15.123]:51326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YMYPQ-00026c-UX for qemu-devel@nongnu.org; Sat, 14 Feb 2015 03:49:05 -0500 Message-ID: <54DF0BF0.8010704@ilande.co.uk> Date: Sat, 14 Feb 2015 08:48:48 +0000 From: Mark Cave-Ayland MIME-Version: 1.0 References: <1422815953-12919-1-git-send-email-mark.cave-ayland@ilande.co.uk> <1422815953-12919-2-git-send-email-mark.cave-ayland@ilande.co.uk> <54CE839C.5030600@reactos.org> In-Reply-To: <54CE839C.5030600@reactos.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCHv2 1/2] m48t59: introduce new year_offset qdev property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?windows-1252?Q?Herv=E9_Poussineau?= , qemu-devel@nongnu.org, atar4qemu@gmail.com On 01/02/15 19:50, Hervé Poussineau wrote: > Le 01/02/2015 19:39, Mark Cave-Ayland a écrit : >> Currently the m48t59 device uses the hardware model in order to determine >> whether the year value is offset from the hardware value. As this will >> soon be required by the x59 model, change the year offset to a qdev >> property and update the callers appropriately. >> >> Signed-off-by: Mark Cave-Ayland > > Hi, > > Is it possible to use a 'base_year' property, like in the mc146818rtc > device? > Usual values will be 0 (for year 2000) and 1968 (for sun4m). > > Regards, > > Hervé Hi Hervé, I've just rebased and updated the patchset to use a "base_year" property similar to mc146818rtc. AFAICT the hack for 0 representing year 2000 isn't relevant here since QEMU doesn't currently implement the century bit and so the year is limited to 0-99. I'll send the new version out shortly. ATB, Mark.