From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNHU0-0006t5-Ry for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:56:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNHTx-0000xY-Ml for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:56:48 -0500 Received: from mail-wi0-x22f.google.com ([2a00:1450:400c:c05::22f]:46155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNHTx-0000v0-GO for qemu-devel@nongnu.org; Mon, 16 Feb 2015 03:56:45 -0500 Received: by mail-wi0-f175.google.com with SMTP id r20so24431810wiv.2 for ; Mon, 16 Feb 2015 00:56:44 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54E1B0C7.1@redhat.com> Date: Mon, 16 Feb 2015 09:56:39 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <87a90hoiup.fsf@blackfin.pond.sub.org> <20150213225421.GB30518@voom.redhat.com> <54DF4B6F.9010301@redhat.com> <20150215030231.GC30518@voom.redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] Did we lose monitor commands pci_add, pci_del? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , David Gibson Cc: Markus Armbruster , QEMU Developers On 15/02/2015 12:12, Peter Maydell wrote: > On 15 February 2015 at 03:02, David Gibson wrote: >> Godammit. Have I mentioned lately how much it pisses me off that we >> have various config symbols and it's never clear which ones make it >> into C and which are only in make. > > That does seem confusing. Is there a reason we can't have a > config-devices.h which gets created from config-devices.mak? Blue Swirl opposed it because we already had qdev_try_create... The problem here was that CONFIG_PCI_HOTPLUG_OLD was in config-devices.mak but not a device. There were other cases before (CONFIG_FDT maybe?) but I think this was the last one. I'd just kill it at this point... Paolo