From: Paolo Bonzini <pbonzini@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] virtio: validate the existence of handle_output before calling it
Date: Mon, 16 Feb 2015 10:29:47 +0100 [thread overview]
Message-ID: <54E1B88B.9010403@redhat.com> (raw)
In-Reply-To: <1423967732.10674.1@smtp.corp.redhat.com>
On 15/02/2015 03:35, Jason Wang wrote:
>
>
> On Sat, Feb 14, 2015 at 4:50 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>>
>> On 12/02/2015 04:05, Jason Wang wrote:
>>> We don't validate the existence of handle_output which may let a buggy
>>> guest to trigger a SIGSEV easily. Fix this by validate its existence
>>> before.
>>>
>>> Cc: qemu-stable@nongnu.org
>>> Cc: Anthony Liguori <aliguori@amazon.com>
>>> Cc: Michael S. Tsirkin <mst@redhat.com>
>>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>>
>> Which queue was causing this?
>>
>> Paolo
>
> The queue that was not used by the device. Though qemu does not use
> them, but it allows guest to do some basic programming. e.g: (for 1q
> virtio-net)
>
> 1) write 10 to queue_sel
> 2) setup an arbitrary pfn
> 3) then notify queue 10
Oh, I see.
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
prev parent reply other threads:[~2015-02-16 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-12 3:05 [Qemu-devel] [PATCH] virtio: validate the existence of handle_output before calling it Jason Wang
2015-02-13 20:18 ` Don Koch
2015-02-15 2:32 ` Jason Wang
2015-02-13 20:50 ` Paolo Bonzini
2015-02-15 2:35 ` Jason Wang
2015-02-16 9:29 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E1B88B.9010403@redhat.com \
--to=pbonzini@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).