Re: [Qemu-devel] [PATCH RFC V2 04/17] hw/acpi: add _CRS method for extra root busses

[Marcel Apfelbaum <marcel@redhat.com>]

On 02/16/2015 11:54 AM, Marcel Apfelbaum wrote:
> Save the IO/mem/bus numbers ranges assigned to the extra root busses
> to be removed from the root bus 0 range.
>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
>   hw/i386/acpi-build.c | 146 +++++++++++++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 146 insertions(+)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index ee1a50a..0822a20 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -719,6 +719,145 @@ static AcpiAml build_prt(void)
>       return method;
>    }
>
> +typedef struct PciRangeEntry {
> +    QLIST_ENTRY(PciRangeEntry) entry;
> +    int64_t base;
> +    int64_t limit;
> +} PciRangeEntry;
> +
> +typedef QLIST_HEAD(PciRangeQ, PciRangeEntry) PciRangeQ;
> +
> +static void pci_range_insert(PciRangeQ *list, int64_t base, int64_t limit) {
> +    PciRangeEntry *entry, *next, *e;
> +
> +    if (!base) {
> +        return;
> +    }
> +
> +   if (limit - base + 1 < 0x1000)
> +       limit = base + 0x1000 - 1;
The above hack is not needed anymore, it was needed before:
  - [PATCH v4 0/3] pc: acpi-build: make linker & RSDP tables dynamic
as a temp solution.

I will remove it from the next version.
Thanks,
Marcel

[...]