From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49706)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YNLkc-0006tI-NL
	for qemu-devel@nongnu.org; Mon, 16 Feb 2015 08:30:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1YNLkb-00076C-QF
	for qemu-devel@nongnu.org; Mon, 16 Feb 2015 08:30:14 -0500
Message-ID: <54E1F0C6.9020006@redhat.com>
Date: Mon, 16 Feb 2015 15:29:42 +0200
From: Marcel Apfelbaum <marcel@redhat.com>
MIME-Version: 1.0
References: <1424080457-13752-1-git-send-email-marcel@redhat.com>
	<1424080457-13752-15-git-send-email-marcel@redhat.com>
	<54E1E9E4.6060202@suse.de>
In-Reply-To: <54E1E9E4.6060202@suse.de>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC V2 14/17] hw/pci: piix - suport
 multiple host bridges
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org
Cc: seabios@seabios.org, kraxel@redhat.com, mst@redhat.com, quintela@redhat.com, alex.williamson@redhat.com, kevin@koconnor.net, qemu-ppc@nongnu.org, hare@suse.de, imammedo@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com, leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net

On 02/16/2015 03:00 PM, Alexander Graf wrote:
>
>
> On 16.02.15 10:54, Marcel Apfelbaum wrote:
>> From: Marcel Apfelbaum <marcel.a@redhat.com>
>>
>> Instead of assuming it has only one bus, it
>> enumerates all the host bridges until it finds
>> the one with bus number corresponding with the
>> config register.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
>
Hi Alexander,
Thank you for the review.


> How 440 specific is this? Wouldn't we need similar code for q35 and gpxe?
For gpxe: I have no idea.
For Q35: PCI Express have native support for extra root bridges by
having multiple Root Complexes(RC), but in this case each RC
handles its separate configuration space.

It may be possible to use the same hack as in PC to expose a
PCIe Root Port as a different host bridge and a primary bus behind
it, but it is out of this series scope.

The series aims to address the limitation that PC machines support
NUMA nodes for CPU/memory but not PCI.

Anyway, we can move the code when neeeded, but since it will
take some and the implementation is not certain, for the moment
is 440 specific.


Thanks,
Marcel
>
>
> Alex
>