From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNRom-0003BN-Jh for qemu-devel@nongnu.org; Mon, 16 Feb 2015 14:58:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNRoj-00062S-HI for qemu-devel@nongnu.org; Mon, 16 Feb 2015 14:58:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53616) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNRoj-00062E-88 for qemu-devel@nongnu.org; Mon, 16 Feb 2015 14:58:53 -0500 Message-ID: <54E24BEF.3080606@redhat.com> Date: Mon, 16 Feb 2015 12:58:39 -0700 From: Eric Blake MIME-Version: 1.0 References: <1423865338-8576-1-git-send-email-jsnow@redhat.com> <1423865338-8576-2-git-send-email-jsnow@redhat.com> In-Reply-To: <1423865338-8576-2-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="59X5aw0kBFtu5jPA9qbA3pRWHjNAiQwxX" Subject: Re: [Qemu-devel] [PATCH v13 01/17] qapi: Add optional field "name" to block dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, armbru@redhat.com, mreitz@redhat.com, vsementsov@parallels.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --59X5aw0kBFtu5jPA9qbA3pRWHjNAiQwxX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/13/2015 03:08 PM, John Snow wrote: > From: Fam Zheng >=20 > This field will be set for user created dirty bitmap. Also pass in an > error pointer to bdrv_create_dirty_bitmap, so when a name is already > taken on this BDS, it can report an error message. This is not global > check, two BDSes can have dirty bitmap with a common name. >=20 > Implemented bdrv_find_dirty_bitmap to find a dirty bitmap by name, will= > be used later when other QMP commands want to reference dirty bitmap by= > name. >=20 > Add bdrv_dirty_bitmap_make_anon. This unsets the name of dirty bitmap. >=20 > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > Reviewed-by: Max Reitz > --- > block.c | 32 +++++++++++++++++++++++++++++++- > block/mirror.c | 2 +- > include/block/block.h | 7 ++++++- > migration/block.c | 2 +- > qapi/block-core.json | 4 +++- > 5 files changed, 42 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --59X5aw0kBFtu5jPA9qbA3pRWHjNAiQwxX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU4kvvAAoJEKeha0olJ0NqZwIIAJyo+wLdxBVGQzKc0E52ePnL GFKgbOIzK9N8cYU10jHtfhLSGLcnrpo1a7oBc+ZCO39XI+ynPOY1OL9JIfnPHwzU abyfHcKsUjYpOA/iajPRc2K2iJAs9OBPHtUwGWcFPA8++6sB+CeIK0i/E/USnnJW rxIbfrFh/tnOys2faasLSt7GCH5TKlhA8wdY7Q8TIqkoQn/71qUzEz9sBKLy6BZU /wU5k/cp5OGw90h6k4Qhjb1A2V68kshZZGHHmOzc7dMt0XIaXWrpAtD4EoQ/j2lS Zb3l3yutQLAJlgLWpbX9Bc08Ea9vF0TIDEX5TmLRu+kxRc0lmc/UPRJHySd9vOg= =VpaW -----END PGP SIGNATURE----- --59X5aw0kBFtu5jPA9qbA3pRWHjNAiQwxX--