From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNSDu-0001wH-Oc for qemu-devel@nongnu.org; Mon, 16 Feb 2015 15:24:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNSDq-000171-Rn for qemu-devel@nongnu.org; Mon, 16 Feb 2015 15:24:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34210) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNSDq-00016u-J3 for qemu-devel@nongnu.org; Mon, 16 Feb 2015 15:24:50 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1GKOojt014020 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 16 Feb 2015 15:24:50 -0500 Message-ID: <54E25211.7020408@redhat.com> Date: Mon, 16 Feb 2015 13:24:49 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424097865-3973-1-git-send-email-armbru@redhat.com> <1424097865-3973-2-git-send-email-armbru@redhat.com> In-Reply-To: <1424097865-3973-2-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mPkQiCsL1Bsm7uuF2mSFn6HWWeuI9a4Id" Subject: Re: [Qemu-devel] [PATCH 01/13] QemuOpts: Convert qemu_opt_set_bool() to Error, fix its use List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, kraxel@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mPkQiCsL1Bsm7uuF2mSFn6HWWeuI9a4Id Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2015 07:44 AM, Markus Armbruster wrote: > Return the Error object instead of reporting it with > qerror_report_err(). >=20 > Change callers that assume the function can't fail to pass > &error_abort, so that should the assumption ever break, it'll break > noisily. >=20 > Turns out all callers outside its unit test assume that. We could > drop the Error ** argument, but that would make the interface less > regular, so don't. >=20 > Signed-off-by: Markus Armbruster > --- > blockdev.c | 6 +++--- > include/qemu/option.h | 3 ++- > tests/test-qemu-opts.c | 10 +++++----- > util/qemu-option.c | 9 ++++----- > util/qemu-sockets.c | 4 ++-- > vl.c | 5 +++-- > 6 files changed, 19 insertions(+), 18 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --mPkQiCsL1Bsm7uuF2mSFn6HWWeuI9a4Id Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU4lIRAAoJEKeha0olJ0Nq/QoH/jfItRDsCPsLEBBgJlHUlxJo cd1+b8g9zXVBHAgVgsVhMnbEvCpq5/qhcNnZe2WcP6DOsSWFqqf8GfAQUdc8KV7d mbn74eXqlOTG++xtKqkRHUHyQJTRlLrQ7E4+QJDQ54WQCs2qQtP6QRfBfRL3AjPT kNjcIOygqgUswDYu8v3S9NE+uvL+kPdb4GT2BsuWuNASQ3gRcT5I7HBC2T27zWxQ 2jwNlNMyaUU6Ddi3BFsXHnFqK847Crof1JhZXpleGeMWIqMOwKi6Kvq2ZyuI4vM6 R37K3dQjhBll73XbB2eGTZszny17c0UzWtyWR/0VSePp+Y+jOzTF0ViwjF1QKwg= =ecpE -----END PGP SIGNATURE----- --mPkQiCsL1Bsm7uuF2mSFn6HWWeuI9a4Id--