From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNSFh-0003ig-DR for qemu-devel@nongnu.org; Mon, 16 Feb 2015 15:26:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNSFd-0001oo-6C for qemu-devel@nongnu.org; Mon, 16 Feb 2015 15:26:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:60069) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNSFc-0001nE-TV for qemu-devel@nongnu.org; Mon, 16 Feb 2015 15:26:41 -0500 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1GKQdMu024122 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Mon, 16 Feb 2015 15:26:40 -0500 Message-ID: <54E2527E.6080001@redhat.com> Date: Mon, 16 Feb 2015 13:26:38 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424097865-3973-1-git-send-email-armbru@redhat.com> <1424097865-3973-3-git-send-email-armbru@redhat.com> In-Reply-To: <1424097865-3973-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lp4oAjCIok9KmC3xhNjUaGhaA5se18olV" Subject: Re: [Qemu-devel] [PATCH 02/13] QemuOpts: Convert qemu_opt_set_number() to Error, fix its use List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, kraxel@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lp4oAjCIok9KmC3xhNjUaGhaA5se18olV Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2015 07:44 AM, Markus Armbruster wrote: > Return the Error object instead of reporting it with > qerror_report_err(). >=20 > Change callers that assume the function can't fail to pass > &error_abort, so that should the assumption ever break, it'll break > noisily. >=20 > Turns out all callers outside its unit test assume that. We could > drop the Error ** argument, but that would make the interface less > regular, so don't. >=20 > Signed-off-by: Markus Armbruster > --- > block.c | 6 +++--- > block/nbd.c | 3 ++- > block/qcow2.c | 2 +- > block/vvfat.c | 3 ++- > include/qemu/option.h | 3 ++- > qemu-img.c | 3 ++- > tests/test-qemu-opts.c | 16 ++++++++-------- > util/qemu-option.c | 9 ++++----- > vl.c | 2 +- > 9 files changed, 25 insertions(+), 22 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lp4oAjCIok9KmC3xhNjUaGhaA5se18olV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU4lJ+AAoJEKeha0olJ0Nq6q8H/jNthLbEAQBFkh+r9sARXHnw /r5G1FZ6R/8tJjiXzWgs70+SxWcbbVTSbz7xIuOwMFrYcGjt31W23ogcEzle45Om k5I7ddVNAsmwVunxRPqGPn224j+3lsxeiZV0n2/He2w2MOL+Rw3SxW9gGc6S8ZRr 3UFhmNoo2yryy235Y18gFExlHBRPAAbsm6jVATwIDTIoMAtXzFMI0uNgm8LnHZUe 6LpXGvSubYDmEeeod0kdFQcM6m+vDfRaJFEPYoU3bVvNOwl6cKw/2vnq9/d4x94r LiXzBP9gJJGQr17nO6ckM1Gpwz8PEEP6PtlC3Keqr3RCaL8H5Dtv8B6F1UrtbdQ= =FF4O -----END PGP SIGNATURE----- --lp4oAjCIok9KmC3xhNjUaGhaA5se18olV--