From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58942) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNTyJ-000310-W6 for qemu-devel@nongnu.org; Mon, 16 Feb 2015 17:16:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNTyG-0002vf-0Z for qemu-devel@nongnu.org; Mon, 16 Feb 2015 17:16:55 -0500 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:57500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNTyF-0002vY-Qa for qemu-devel@nongnu.org; Mon, 16 Feb 2015 17:16:51 -0500 Received: by mail-wi0-f177.google.com with SMTP id bs8so29179911wib.4 for ; Mon, 16 Feb 2015 14:16:51 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54E26C4E.6050103@redhat.com> Date: Mon, 16 Feb 2015 23:16:46 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1424123271-7656-1-git-send-email-sfeldma@gmail.com> <1424123271-7656-8-git-send-email-sfeldma@gmail.com> In-Reply-To: <1424123271-7656-8-git-send-email-sfeldma@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: sfeldma@gmail.com, qemu-devel@nongnu.org, jiri@resnulli.us, roopa@cumulusnetworks.com, john.fastabend@gmail.com, eblake@redhat.com, stefanha@gmail.com, dsahern@gmail.com, jasowang@redhat.com On 16/02/2015 22:47, sfeldma@gmail.com wrote: > From: Scott Feldman > > Add QMP/HMP support for rocker devices. This is mostly for debugging purposes > to see inside the device's tables and port configurations. Some examples: > > (qemu) info rocker sw1 > name: sw1 > id: 0x0000013512005452 > ports: 4 I think CONFIG_ROCKER doesn't work as intended. It's not exported to C files. I would just merge the other nine patches for 2.3. Paolo