From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44160) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNY44-0008Nl-D8 for qemu-devel@nongnu.org; Mon, 16 Feb 2015 21:39:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNY3z-0000Xg-7X for qemu-devel@nongnu.org; Mon, 16 Feb 2015 21:39:08 -0500 Received: from mail-ig0-x22f.google.com ([2607:f8b0:4001:c05::22f]:48486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNY3z-0000XR-2M for qemu-devel@nongnu.org; Mon, 16 Feb 2015 21:39:03 -0500 Received: by mail-ig0-f175.google.com with SMTP id hn18so27118809igb.2 for ; Mon, 16 Feb 2015 18:39:02 -0800 (PST) Message-ID: <54E2A9B5.3070503@gmail.com> Date: Mon, 16 Feb 2015 19:38:45 -0700 From: David Ahern MIME-Version: 1.0 References: <1424123271-7656-1-git-send-email-sfeldma@gmail.com> <1424123271-7656-8-git-send-email-sfeldma@gmail.com> <54E26C4E.6050103@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 07/10] qmp: add rocker device support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Scott Feldman , Paolo Bonzini Cc: =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Stefan Hajnoczi , Roopa Prabhu , john fastabend , QEMU Developers , "jasowang@redhat.com" On 2/16/15 3:37 PM, Scott Feldman wrote: > On Mon, Feb 16, 2015 at 5:16 PM, Paolo Bonzini wrote: >> >> >> On 16/02/2015 22:47, sfeldma@gmail.com wrote: >>> From: Scott Feldman >>> >>> Add QMP/HMP support for rocker devices. This is mostly for debugging purposes >>> to see inside the device's tables and port configurations. Some examples: >>> >>> (qemu) info rocker sw1 >>> name: sw1 >>> id: 0x0000013512005452 >>> ports: 4 >> >> I think CONFIG_ROCKER doesn't work as intended. It's not exported to C >> files. > > It's working fine. What do you think it broken? If you take out CONFIG_ROCKER (e.g., from default-configs/pci.mak or ./x86_64-softmmu/config-devices.mak) you get: LINK x86_64-softmmu/qemu-system-x86_64 ../qmp-marshal.o: In function `qmp_marshal_input_query_rocker': /home/dahern/sw/kvm/qemu.git/build/qmp-marshal.c:5591: undefined reference to `qmp_query_rocker' ../qmp-marshal.o: In function `qmp_marshal_input_query_rocker_ports': /home/dahern/sw/kvm/qemu.git/build/qmp-marshal.c:5652: undefined reference to `qmp_query_rocker_ports' ../qmp-marshal.o: In function `qmp_marshal_input_query_rocker_of_dpa_flows': /home/dahern/sw/kvm/qemu.git/build/qmp-marshal.c:5725: undefined reference to `qmp_query_rocker_of_dpa_flows' ../qmp-marshal.o: In function `qmp_marshal_input_query_rocker_of_dpa_groups': /home/dahern/sw/kvm/qemu.git/build/qmp-marshal.c:5802: undefined reference to `qmp_query_rocker_of_dpa_groups' collect2: error: ld returned 1 exit status Makefile:180: recipe for target 'qemu-system-x86_64' failed make[1]: *** [qemu-system-x86_64] Error 1 Makefile:169: recipe for target 'subdir-x86_64-softmmu' failed make: *** [subdir-x86_64-softmmu] Error 2 > >> I would just merge the other nine patches for 2.3. > > I disagree. qmp/hmp is very important to rocker. It would be nearly > impossible to debug large/complicated networking setups without having > a back-door view into the device. qmp/hmp are perfect for this. > Since rocker's primary purpose is for development of OS support for > traditional L2/L3 offloads as well as flow-based offloads, it is > important to enable this debug tool. Taking all of them but QMP should lighten the review load and re-do on the patch set to load to just the qmp changes. David