From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54970) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNh4w-0006I2-0n for qemu-devel@nongnu.org; Tue, 17 Feb 2015 07:16:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNh4s-0006Yi-ND for qemu-devel@nongnu.org; Tue, 17 Feb 2015 07:16:37 -0500 Received: from mail.uni-paderborn.de ([131.234.142.9]:47005) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNh4s-0006XX-Gp for qemu-devel@nongnu.org; Tue, 17 Feb 2015 07:16:34 -0500 Message-ID: <54E33F81.7090701@mail.uni-paderborn.de> Date: Tue, 17 Feb 2015 13:17:53 +0000 From: Bastian Koppelmann MIME-Version: 1.0 References: <1423673343-25688-1-git-send-email-kbastian@mail.uni-paderborn.de> In-Reply-To: <1423673343-25688-1-git-send-email-kbastian@mail.uni-paderborn.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] TriCore: Add RRR1 and RRR2 instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: rth@twiddle.net On 02/11/2015 04:48 PM, Bastian Koppelmann wrote: > Hi, > > the patchset fixes two minor bugs and takes care of all the packed/fixed point > mac instructions. So far I only implemented all the multiply-add instructions, > since the multiply-sub instructions are similar and I don't want the reviewers > to find the same mistakes twice. Once these are reviewed I will send another > patchset containing all the multiply-sub instructions. > I do plan on mirroring the multiply-add instructions, which seems okay. However > if there are ideas to make this more clean, let me know. > > Cheers, > Bastian > > v1 -> v2: > * fix obvious style issues found by checkpatch > > Bastian Koppelmann (6): > target-tricore: Fix RLC_ADDI, RLC_ADDIH using wrong microcode helper > target-tricore: fix msub32_suov return wrong results > target-tricore: Add instructions of RRR2 opcode format > target-tricore: Add instructions of RRR1 opcode format, which have > 0x83 as first opcode > target-tricore: Add instructions of RRR1 opcode format, which have > 0x43 as first opcode > target-tricore: Add instructions of RRR1 opcode format, which have > 0xc3 as first opcode > > target-tricore/helper.h | 9 + > target-tricore/op_helper.c | 374 +++++++++- > target-tricore/translate.c | 1391 ++++++++++++++++++++++++++++++++++++-- > target-tricore/tricore-opcodes.h | 10 +- > 4 files changed, 1728 insertions(+), 56 deletions(-) > > -- > 2.3.0 > > ping? Cheers, Bastian