Re: [Qemu-devel] [PATCH v6 09/24] qcow2: More helpers for refcount modification

[Max Reitz <mreitz@redhat.com>]

On 2015-02-17 at 08:38, Kevin Wolf wrote:
> Am 10.02.2015 um 21:28 hat Max Reitz geschrieben:
>> Add helper functions for getting and setting refcounts in a refcount
>> array for any possible refcount order, and choose the correct one during
>> refcount initialization.
>>
>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
>> ---
>>   block/qcow2-refcount.c | 121 ++++++++++++++++++++++++++++++++++++++++++++++++-
>>   1 file changed, 119 insertions(+), 2 deletions(-)
>>
>> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
>> index b9034ae..c9f9f4f 100644
>> --- a/block/qcow2-refcount.c
>> +++ b/block/qcow2-refcount.c
>> @@ -32,10 +32,49 @@ static int QEMU_WARN_UNUSED_RESULT update_refcount(BlockDriverState *bs,
>>                               int64_t offset, int64_t length, uint64_t addend,
>>                               bool decrease, enum qcow2_discard_type type);
>>   
>> +static uint64_t get_refcount_ro0(const void *refcount_array, uint64_t index);
>> +static uint64_t get_refcount_ro1(const void *refcount_array, uint64_t index);
>> +static uint64_t get_refcount_ro2(const void *refcount_array, uint64_t index);
>> +static uint64_t get_refcount_ro3(const void *refcount_array, uint64_t index);
>>   static uint64_t get_refcount_ro4(const void *refcount_array, uint64_t index);
>> +static uint64_t get_refcount_ro5(const void *refcount_array, uint64_t index);
>> +static uint64_t get_refcount_ro6(const void *refcount_array, uint64_t index);
>>   
>> +static void set_refcount_ro0(void *refcount_array, uint64_t index,
>> +                             uint64_t value);
>> +static void set_refcount_ro1(void *refcount_array, uint64_t index,
>> +                             uint64_t value);
>> +static void set_refcount_ro2(void *refcount_array, uint64_t index,
>> +                             uint64_t value);
>> +static void set_refcount_ro3(void *refcount_array, uint64_t index,
>> +                             uint64_t value);
>>   static void set_refcount_ro4(void *refcount_array, uint64_t index,
>>                                uint64_t value);
>> +static void set_refcount_ro5(void *refcount_array, uint64_t index,
>> +                             uint64_t value);
>> +static void set_refcount_ro6(void *refcount_array, uint64_t index,
>> +                             uint64_t value);
> Hm, lots of forward declarations. Can't we put the implementation here?

Of course we can. I just personally found it cleaner this way 
(qcow2_refcount_init() being the first function implementation in 
qcow2-refcount.c). I'm fine either way.

Max