* [Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState
@ 2015-02-17 13:49 Kevin Wolf
2015-02-17 14:15 ` Max Reitz
2015-02-17 15:36 ` Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2015-02-17 13:49 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, stefanha
The only user went away five years ago with commit a9420734 ('qcow2:
Simplify image creation'). It's about time to remove it.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/qcow2.h | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/block/qcow2.h b/block/qcow2.h
index 17c9a3f..a9108f5 100644
--- a/block/qcow2.h
+++ b/block/qcow2.h
@@ -277,17 +277,6 @@ typedef struct BDRVQcowState {
bool cache_discards;
} BDRVQcowState;
-/* XXX: use std qcow open function ? */
-typedef struct QCowCreateState {
- int cluster_size;
- int cluster_bits;
- uint16_t *refcount_block;
- uint64_t *refcount_table;
- int64_t l1_table_offset;
- int64_t refcount_table_offset;
- int64_t refcount_block_offset;
-} QCowCreateState;
-
struct QCowAIOCB;
typedef struct Qcow2COWRegion {
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState
2015-02-17 13:49 [Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState Kevin Wolf
@ 2015-02-17 14:15 ` Max Reitz
2015-02-17 15:36 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2015-02-17 14:15 UTC (permalink / raw)
To: Kevin Wolf, qemu-devel; +Cc: stefanha
On 2015-02-17 at 08:49, Kevin Wolf wrote:
> The only user went away five years ago with commit a9420734 ('qcow2:
> Simplify image creation'). It's about time to remove it.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.h | 11 -----------
> 1 file changed, 11 deletions(-)
Reviewed-by: Max Reitz <mreitz@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState
2015-02-17 13:49 [Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState Kevin Wolf
2015-02-17 14:15 ` Max Reitz
@ 2015-02-17 15:36 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2015-02-17 15:36 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 377 bytes --]
On Tue, Feb 17, 2015 at 02:49:25PM +0100, Kevin Wolf wrote:
> The only user went away five years ago with commit a9420734 ('qcow2:
> Simplify image creation'). It's about time to remove it.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.h | 11 -----------
> 1 file changed, 11 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-17 15:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-17 13:49 [Qemu-devel] [PATCH] qcow2: Remove unused struct QCowCreateState Kevin Wolf
2015-02-17 14:15 ` Max Reitz
2015-02-17 15:36 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).