Re: [Qemu-devel] [PATCH 05/10] qga: introduce three guest memory block commmands with stubs

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

On 02/16/2015 08:14 PM, Michael Roth wrote:
> From: zhanghailiang <zhang.zhanghailiang@huawei.com>
> 
> Introduce three new guest commands:
> guest-get-memory-blocks, guest-set-memory-blocks, guest-get-memory-block-size.

Sorry for the late review, but I think guest-get-memory-block-size is
the wrong command to add.


> +##
> +# @guest-get-memory-block-size:
> +#
> +# Get the the size (in bytes) of a memory block in guest.
> +# It is the unit of memory block online/offline operation (also called Logical
> +# Memory Hotplug).
> +#
> +# Returns: memory block size in bytes.
> +#
> +# Since 2.3
> +##
> +{ 'command': 'guest-get-memory-block-size',
> +  'returns': 'int' }

Any QAPI command that returns a bare int instead of a dictionary is
non-extensible, and therefore of suspect design.  I think it would be
better to have:

{ 'command': 'guest-get-memory-block-info',
  'returns': { 'size': 'int' } }

to allow for future extension.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]