From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNk42-00057s-GR for qemu-devel@nongnu.org; Tue, 17 Feb 2015 10:27:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNk3y-0002TW-BO for qemu-devel@nongnu.org; Tue, 17 Feb 2015 10:27:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34628) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNk3y-0002TN-2r for qemu-devel@nongnu.org; Tue, 17 Feb 2015 10:27:50 -0500 Message-ID: <54E35DEF.3020309@redhat.com> Date: Tue, 17 Feb 2015 08:27:43 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424142892-7275-1-git-send-email-mdroth@linux.vnet.ibm.com> <1424142892-7275-4-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1424142892-7275-4-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="klX9KnNQlnA4KkCVkVPdXoeGRjljIRoGC" Subject: Re: [Qemu-devel] [PATCH 03/10] guest agent: guest-file-open: refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Simon Zolin , "Denis V. Lunev" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --klX9KnNQlnA4KkCVkVPdXoeGRjljIRoGC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2015 08:14 PM, Michael Roth wrote: > From: Simon Zolin >=20 > Moved the code that sets non-blocking flag on fd into a separate functi= on. >=20 > Signed-off-by: Simon Zolin > Reviewed-by: Roman Kagan > Signed-off-by: Denis V. Lunev > CC: Michael Roth > CC: Eric Blake > Signed-off-by: Michael Roth > --- > qga/commands-posix.c | 31 +++++++++++++++++++++++-------- > 1 file changed, 23 insertions(+), 8 deletions(-) >=20 > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index 57409d0..ed527a3 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c > @@ -376,13 +376,33 @@ safe_open_or_create(const char *path, const char = *mode, Error **errp) > return NULL; > } > =20 > +static int guest_file_toggle_flags(int fd, int flags, bool set, Error = **err) > +{ Why are you reinventing qemu_set_nonblock()? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --klX9KnNQlnA4KkCVkVPdXoeGRjljIRoGC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU413vAAoJEKeha0olJ0NqFlsH/2XcydbkJEcn34n30+JS71tL uJnU3zATy0q5w/Uuxoswj0WrffpEst0raWgjbI5TB4HeIiLw1CZFrHSlIyMuCzdf aL8bmFZjOg1lSgwbyvpeZPGRvHdxqeZtNS65ePZCERtZ8eeBM1EoQfMqopfCrQ0O Gs5tK4BXBuwY8oRhLLMipu3AtcpgQPmmZJMJQGAJPck/Wvy0zKGelYPcl7nmITOb 0YaYQWWdySlZzvY3nUWvc5iemSIZ5YMYGwi6wlZLZp2bUhPFUbYbFWSR8+OwHPDK zv2MGdTTrLKW1LIhA5FKAfYi2/XWlmSP7qAH7XoaBa6lcquqxLGp1RH5JwU7T7w= =Af8F -----END PGP SIGNATURE----- --klX9KnNQlnA4KkCVkVPdXoeGRjljIRoGC--