From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNk50-00062v-SQ for qemu-devel@nongnu.org; Tue, 17 Feb 2015 10:28:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YNk4v-0002hq-Ud for qemu-devel@nongnu.org; Tue, 17 Feb 2015 10:28:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YNk4v-0002hm-Mb for qemu-devel@nongnu.org; Tue, 17 Feb 2015 10:28:49 -0500 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1HFSnns008190 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 17 Feb 2015 10:28:49 -0500 Message-ID: <54E35E30.6060605@redhat.com> Date: Tue, 17 Feb 2015 08:28:48 -0700 From: Eric Blake MIME-Version: 1.0 References: <1424097865-3973-1-git-send-email-armbru@redhat.com> <1424097865-3973-5-git-send-email-armbru@redhat.com> In-Reply-To: <1424097865-3973-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uEv9sPm6l30GQb80XW3Sg4P2nR0SFl5uC" Subject: Re: [Qemu-devel] [PATCH 04/13] qemu-img: Suppress unhelpful extra errors in convert, resize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, kraxel@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uEv9sPm6l30GQb80XW3Sg4P2nR0SFl5uC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/16/2015 07:44 AM, Markus Armbruster wrote: > add_old_style_options() for img_convert() and img_resize() use > qemu_opt_set(), which reports errors with qerror_report_err(). Its > error messages aren't helpful here, the caller reports one that > actually makes sense. Reproducer: >=20 > $ qemu-img convert -B raw in.img out.img > qemu-img: Invalid parameter 'backing_file' > qemu-img: Backing file not supported for file format 'raw' >=20 > Switch to qemu_opt_set_err() to get rid of the unwanted messages. >=20 > Signed-off-by: Markus Armbruster > --- > qemu-img.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) With pre-req patch in place, Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uEv9sPm6l30GQb80XW3Sg4P2nR0SFl5uC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJU414wAAoJEKeha0olJ0Nqlb4H/1i43ZVIWhvh/43ekw4BjsmW gDrxtSj4kQeZwEtJeBfN9vzLSXbddDhmFwXwj8bK1XTf1lDvrNLT0l4axCvAmerd Gmg9xxwBoUwybLiADTpvRO+/Ovqdg0bvRzVWOxOn+wQcGyUmdwttzhj6JLTpm3yu jVHKvcx8l+lE8BHkP+PstPKYkavEOMZTw2w7NXMJ3hgvlIe7Phpqgb8UcLo/MWlW w8GrUg04cT9d5mMEACvXxCDcFHe5nFpIyeyXuHG6lhlr69xFSGSs++JIJV21Wxdh LkbY0KWuwT44rDgwqaVNZwSG1tUeY3f7s3JlhNcYQVz54bUtWYT6i4VPs+8n0xo= =fK/A -----END PGP SIGNATURE----- --uEv9sPm6l30GQb80XW3Sg4P2nR0SFl5uC--